Re: [PR] Make FAB auth manager login process compatible with Airflow 3 UI [airflow]
vincbeck merged PR #45765: URL: https://github.com/apache/airflow/pull/45765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make FAB auth manager login process compatible with Airflow 3 UI [airflow]
vincbeck commented on code in PR #45765:
URL: https://github.com/apache/airflow/pull/45765#discussion_r1922817575
##
providers/src/airflow/providers/fab/www/extensions/init_appbuilder.py:
##
@@ -500,7 +512,11 @@ def add_view_no_menu(self, baseview, endpoint=None,
static_folder=None):
@property
def get_url_for_index(self):
-# TODO: Return the fast api application homepage
+if not self.enable_plugins and g.user is not None and
g.user.is_authenticated:
+# If plugins are disabled and the user is authenticated, it should
be redirected to the Airflow 3 UI index page along with the JWT token
+token = get_auth_manager().get_jwt_token(g.user)
+return f"https://localhost:29091/webapp?token={token}";
Review Comment:
I found a solution without creating a config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Make FAB auth manager login process compatible with Airflow 3 UI [airflow]
pierrejeambrun commented on code in PR #45765:
URL: https://github.com/apache/airflow/pull/45765#discussion_r1922441883
##
providers/src/airflow/providers/fab/www/extensions/init_appbuilder.py:
##
@@ -500,7 +512,11 @@ def add_view_no_menu(self, baseview, endpoint=None,
static_folder=None):
@property
def get_url_for_index(self):
-# TODO: Return the fast api application homepage
+if not self.enable_plugins and g.user is not None and
g.user.is_authenticated:
+# If plugins are disabled and the user is authenticated, it should
be redirected to the Airflow 3 UI index page along with the JWT token
+token = get_auth_manager().get_jwt_token(g.user)
+return f"https://localhost:29091/webapp?token={token}";
Review Comment:
Yes I think a config would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Make FAB auth manager login process compatible with Airflow 3 UI [airflow]
vincbeck commented on code in PR #45765:
URL: https://github.com/apache/airflow/pull/45765#discussion_r1920808886
##
providers/src/airflow/providers/fab/www/extensions/init_appbuilder.py:
##
@@ -500,7 +512,11 @@ def add_view_no_menu(self, baseview, endpoint=None,
static_folder=None):
@property
def get_url_for_index(self):
-# TODO: Return the fast api application homepage
+if not self.enable_plugins and g.user is not None and
g.user.is_authenticated:
+# If plugins are disabled and the user is authenticated, it should
be redirected to the Airflow 3 UI index page along with the JWT token
+token = get_auth_manager().get_jwt_token(g.user)
+return f"https://localhost:29091/webapp?token={token}";
Review Comment:
This is obviously not ideal. Should we create a config to store that value?
Important point: it MUST be an HTTPS endpoint, otherwise FLask wont make the
redirect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
