Re: [PR] Move Self to observability shared package [airflow]
potiuk commented on PR #59140: URL: https://github.com/apache/airflow/pull/59140#issuecomment-3620936346 > Since its only used for type checking, cant we just add the "typing-extensions" path? I think not - I prefer not to depend on "typing-extensions" version of "Self" when we are already on Python 3.11+ in this case. Also having it this way makes it easy to have "rolling deprecation removal". When we move to Python 3.11+ next October - we will know we have to remove this completely. If we import from `typing_extensions` - there is no obvious signal that we should remove this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move Self to observability shared package [airflow]
amoghrajesh commented on PR #59140: URL: https://github.com/apache/airflow/pull/59140#issuecomment-3620865823 Since its only used for type checking, cant we just add the "typing-extensions" path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move Self to observability shared package [airflow]
potiuk commented on PR #59140: URL: https://github.com/apache/airflow/pull/59140#issuecomment-3620817757 cc: @xBis7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
