Re: [PR] Move asset events to its own tab [airflow]
bbovenzi commented on PR #51625: URL: https://github.com/apache/airflow/pull/51625#issuecomment-2967087494 Taking a look at the UX here. Do you mind moving the "Asset Events" tab to come before Audit Log, Code and Details? Also, I wonder if we want to look up if we should even show the tab (ie: is this task instance or dag run ever connected to an asset?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move asset events to its own tab [airflow]
pierrejeambrun commented on PR #51625: URL: https://github.com/apache/airflow/pull/51625#issuecomment-2966709691 Manual backport https://github.com/apache/airflow/pull/51625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move asset events to its own tab [airflow]
github-actions[bot] commented on PR #51625: URL: https://github.com/apache/airflow/pull/51625#issuecomment-2966677372 ### Backport failed to create: v3-0-test. View the failure log Run details Status Branch Result ❌ v3-0-test https://github.com/apache/airflow/commit/e8505aaff3a081b87c57bb725598af1b2bb7c656";> You can attempt to backport this manually by running: ```bash cherry_picker e8505aa v3-0-test ``` This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move asset events to its own tab [airflow]
pierrejeambrun merged PR #51625: URL: https://github.com/apache/airflow/pull/51625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move asset events to its own tab [airflow]
pierrejeambrun commented on code in PR #51625:
URL: https://github.com/apache/airflow/pull/51625#discussion_r2142119061
##
airflow-core/src/airflow/ui/src/i18n/locales/en/dag.json:
##
@@ -89,10 +89,11 @@
}
},
"tabs": {
+"asset_events": "Asset Events",
"backfills": "Backfills",
"code": "Code",
"details": "Details",
-"events": "Events",
+"events": "Audit",
Review Comment:
Done
##
airflow-core/src/airflow/ui/src/pages/Run/Run.tsx:
##
@@ -29,9 +29,10 @@ import { Header } from "./Header";
const tabs = [
{ icon: , label: "Task Instances", value: "" },
- { icon: , label: "Events", value: "events" },
+ { icon: , label: "Audit", value: "events" },
Review Comment:
Done
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/TaskInstance.tsx:
##
@@ -36,9 +36,10 @@ const tabs = [
{ icon: , label: "Logs", value: "" },
{ icon: , label: "Rendered Templates", value:
"rendered_templates" },
{ icon: , label: "XCom", value: "xcom" },
- { icon: , label: "Events", value: "events" },
+ { icon: , label: "Audit", value: "events" },
Review Comment:
Done
##
airflow-core/src/airflow/ui/src/pages/Task/Task.tsx:
##
@@ -31,7 +31,7 @@ import { Header } from "./Header";
const tabs = [
{ icon: , label: "Overview", value: "" },
{ icon: , label: "Task Instances", value: "task_instances"
},
- { icon: , label: "Events", value: "events" },
+ { icon: , label: "Audit", value: "events" },
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Move asset events to its own tab [airflow]
bbovenzi commented on code in PR #51625:
URL: https://github.com/apache/airflow/pull/51625#discussion_r2140877229
##
airflow-core/src/airflow/ui/src/pages/Run/Run.tsx:
##
@@ -29,9 +29,10 @@ import { Header } from "./Header";
const tabs = [
{ icon: , label: "Task Instances", value: "" },
- { icon: , label: "Events", value: "events" },
+ { icon: , label: "Audit", value: "events" },
Review Comment:
```suggestion
{ icon: , label: "Audit Log", value: "events" },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Move asset events to its own tab [airflow]
bbovenzi commented on code in PR #51625:
URL: https://github.com/apache/airflow/pull/51625#discussion_r2140875207
##
airflow-core/src/airflow/ui/src/i18n/locales/en/dag.json:
##
@@ -89,10 +89,11 @@
}
},
"tabs": {
+"asset_events": "Asset Events",
"backfills": "Backfills",
"code": "Code",
"details": "Details",
-"events": "Events",
+"events": "Audit",
Review Comment:
```suggestion
"events": "Audit Log",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Move asset events to its own tab [airflow]
bbovenzi commented on code in PR #51625:
URL: https://github.com/apache/airflow/pull/51625#discussion_r2140877570
##
airflow-core/src/airflow/ui/src/pages/Task/Task.tsx:
##
@@ -31,7 +31,7 @@ import { Header } from "./Header";
const tabs = [
{ icon: , label: "Overview", value: "" },
{ icon: , label: "Task Instances", value: "task_instances"
},
- { icon: , label: "Events", value: "events" },
+ { icon: , label: "Audit", value: "events" },
Review Comment:
```suggestion
{ icon: , label: "Audit Log", value: "events" },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Move asset events to its own tab [airflow]
bbovenzi commented on code in PR #51625:
URL: https://github.com/apache/airflow/pull/51625#discussion_r2140877951
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/TaskInstance.tsx:
##
@@ -36,9 +36,10 @@ const tabs = [
{ icon: , label: "Logs", value: "" },
{ icon: , label: "Rendered Templates", value:
"rendered_templates" },
{ icon: , label: "XCom", value: "xcom" },
- { icon: , label: "Events", value: "events" },
+ { icon: , label: "Audit", value: "events" },
Review Comment:
```suggestion
{ icon: , label: "Audit Log", value: "events" },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Move asset events to its own tab [airflow]
pierrejeambrun commented on PR #51625: URL: https://github.com/apache/airflow/pull/51625#issuecomment-2963635909 This makes me realize that with the translation work, we lost the `Asset Events` (for TI) vs `Source Asset Events` (for dag run asset scheduled triggered). I will open a follow up PR to make that distinction again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
