Re: [PR] Move dags-folder bundle to LocalDagBundle; rename kwarg [airflow]
jedcunningham merged PR #45721: URL: https://github.com/apache/airflow/pull/45721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move dags-folder bundle to LocalDagBundle; rename kwarg [airflow]
jedcunningham commented on code in PR #45721: URL: https://github.com/apache/airflow/pull/45721#discussion_r1919476794 ## airflow/dag_processing/bundles/local.py: ## @@ -19,21 +19,25 @@ from pathlib import Path +from airflow import settings from airflow.dag_processing.bundles.base import BaseDagBundle class LocalDagBundle(BaseDagBundle): """ Local DAG bundle - exposes a local directory as a DAG bundle. -:param local_folder: Local folder where the DAGs are stored +:param directory: Local directory where the DAGs are stored Review Comment: Good call, I was taking inspiration from `os`, but I must not have looked very well because I see way more `path` now that I look again 🙃 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move dags-folder bundle to LocalDagBundle; rename kwarg [airflow]
dstandish commented on code in PR #45721: URL: https://github.com/apache/airflow/pull/45721#discussion_r1919363562 ## airflow/dag_processing/bundles/local.py: ## @@ -19,21 +19,25 @@ from pathlib import Path +from airflow import settings from airflow.dag_processing.bundles.base import BaseDagBundle class LocalDagBundle(BaseDagBundle): """ Local DAG bundle - exposes a local directory as a DAG bundle. -:param local_folder: Local folder where the DAGs are stored +:param directory: Local directory where the DAGs are stored Review Comment: path feels a little more familiar but 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move dags-folder bundle to LocalDagBundle; rename kwarg [airflow]
jedcunningham closed pull request #45721: Move dags-folder bundle to LocalDagBundle; rename kwarg URL: https://github.com/apache/airflow/pull/45721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
