Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
potiuk merged PR #49396: URL: https://github.com/apache/airflow/pull/49396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
gopidesupavan commented on PR #49396: URL: https://github.com/apache/airflow/pull/49396#issuecomment-2813650971 This is ready for review , one test failure which has already raised PR by Daniel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
gopidesupavan commented on code in PR #49396: URL: https://github.com/apache/airflow/pull/49396#discussion_r2048706339 ## providers/standard/tests/unit/standard/utils/test_sensor_helper.py: ## @@ -42,7 +41,11 @@ from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS if AIRFLOW_V_3_0_PLUS: +from airflow.providers.standard.operators.empty import EmptyOperator from airflow.utils.types import DagRunTriggeredByType +else: +# TODO: Remove this import when we drop support for Airflow 2 +from airflow.operators.empty import EmptyOperator # type: ignore[no-redef] Review Comment: my bad yeah, confused :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
gopidesupavan commented on code in PR #49396: URL: https://github.com/apache/airflow/pull/49396#discussion_r2048877700 ## providers/standard/tests/unit/standard/utils/test_sensor_helper.py: ## @@ -47,6 +47,8 @@ if TYPE_CHECKING: from sqlalchemy.orm.session import Session +pytestmark = pytest.mark.db_test Review Comment: Alright the `TestSensorHelper` is purely for AF2, its not required for AF3. in AF3 we used `task-instances/states` endpoint with task-sdk to fetch the task states. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
gopidesupavan commented on code in PR #49396: URL: https://github.com/apache/airflow/pull/49396#discussion_r2048764178 ## providers/standard/tests/unit/standard/utils/test_sensor_helper.py: ## @@ -47,6 +47,8 @@ if TYPE_CHECKING: from sqlalchemy.orm.session import Session +pytestmark = pytest.mark.db_test Review Comment: Yeah mostly it is for AF2, am sure the tests will explode for some, i may need to fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
amoghrajesh commented on code in PR #49396: URL: https://github.com/apache/airflow/pull/49396#discussion_r2048757488 ## providers/standard/tests/unit/standard/utils/test_sensor_helper.py: ## @@ -47,6 +47,8 @@ if TYPE_CHECKING: from sqlalchemy.orm.session import Session +pytestmark = pytest.mark.db_test Review Comment: We need this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
eladkal commented on code in PR #49396: URL: https://github.com/apache/airflow/pull/49396#discussion_r2048694180 ## providers/standard/tests/unit/standard/utils/test_sensor_helper.py: ## @@ -42,7 +41,11 @@ from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS if AIRFLOW_V_3_0_PLUS: +from airflow.providers.standard.operators.empty import EmptyOperator from airflow.utils.types import DagRunTriggeredByType +else: +# TODO: Remove this import when we drop support for Airflow 2 +from airflow.operators.empty import EmptyOperator # type: ignore[no-redef] Review Comment: standard provider is compatible with 2.9 which is the min Airflow version of providers You can just import directly from provider without checking airflow version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move test_sensor_helper.py to standard provider tests [airflow]
gopidesupavan commented on PR #49396: URL: https://github.com/apache/airflow/pull/49396#issuecomment-2812458818 alright this got missed 😞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
