Re: [PR] Move webserver config to fab provider [airflow]
github-actions[bot] commented on PR #50774: URL: https://github.com/apache/airflow/pull/50774#issuecomment-2894223771 ### Backport failed to create: v3-0-test. View the failure log Run details Status Branch Result ❌ v3-0-test https://github.com/apache/airflow/commit/649309e4e5fdf18e4a4be140069c0f9581f6";> You can attempt to backport this manually by running: ```bash cherry_picker 649309e v3-0-test ``` This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
pierrejeambrun merged PR #50774: URL: https://github.com/apache/airflow/pull/50774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
eladkal commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2097302723 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: OK then all is good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
pierrejeambrun commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096578637 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: Indeed I forgot about that part but that was the original intent, continuation of the previous cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
potiuk commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096304091 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: > The only case we must specify future version in versions is when you wish to set it as min version for another package I think that was the intention here (airflow has fab provider >=2.2.0). And we need to do it if we want defaults to work - this is a one-time (or actually continuation of the previous) cleanups and I think it's worth doing it. The problem is that currently the old provider will not get the right default value when it is moved to FAB section and Airflow 3.0.2 will install older provider version. Those are the teething problems we need to solve now I think by cleaning the configs, otherwise it might cause the problem for our users. And setting the right provider version now is the only way - I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
eladkal commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096161228 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: I dont think we cross refrence it. Some settings dont have version_added at all. The only case we must specify future version in versions is when you wish to set it as min version for another package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
pierrejeambrun commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096141038 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: I won’t be able to point to 2.2.0 in version added if the versions does not specify 2.2.0 I think. Last time in a similar setup I had documentation build error. But maybe that was caused by something else, I’ll try again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
eladkal commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096137342 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: version_added is the next feature release 2.2.0 that is OK. I specify the version number during release peocess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
eladkal commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096137342 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: version_added is the next feature release 2.2.0 that is OK. I specify the version number during release process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
pierrejeambrun commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096088948 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: Ok and I point to `2.1.0` the `version_added` (latest provider release) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
pierrejeambrun commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096088948 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: Ok and I point to `2.1.0` the versions introduced ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
eladkal commented on code in PR #50774: URL: https://github.com/apache/airflow/pull/50774#discussion_r2096027629 ## providers/fab/provider.yaml: ## @@ -35,6 +35,7 @@ source-date-epoch: 1747132761 # In such case adding >= NEW_VERSION and bumping to NEW_VERSION in a provider have # to be done in the same PR versions: + - 2.2.0 Review Comment: Remove this entry. It causes issue with release procedure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move webserver config to fab provider [airflow]
pierrejeambrun commented on PR #50774: URL: https://github.com/apache/airflow/pull/50774#issuecomment-2891323825 cc: @eladkal for fab provider version update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
