Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
romsharon98 closed pull request #45483: Pass specific env vars to logGroomerSideCar URL: https://github.com/apache/airflow/pull/45483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
romsharon98 commented on PR #45483: URL: https://github.com/apache/airflow/pull/45483#issuecomment-2748033601 > Do we still need this PR after https://github.com/apache/airflow/pull/46003 was merged? I think no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
github-actions[bot] commented on PR #45483: URL: https://github.com/apache/airflow/pull/45483#issuecomment-2744712536 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
eladkal commented on PR #45483: URL: https://github.com/apache/airflow/pull/45483#issuecomment-2630136744 Do we still need this PR after https://github.com/apache/airflow/pull/46003 was merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
jedcunningham commented on code in PR #45483:
URL: https://github.com/apache/airflow/pull/45483#discussion_r1929219709
##
chart/templates/scheduler/scheduler-deployment.yaml:
##
@@ -264,6 +264,7 @@ spec:
{{- if .Values.scheduler.logGroomerSidecar.args }}
args: {{- tpl (toYaml .Values.scheduler.logGroomerSidecar.args) . |
nindent 12 }}
{{- end }}
+ envFrom: {{- include "custom_airflow_environment_from" . | default
"\n []" | indent 10 }}
Review Comment:
It feels a little weird to include the custom env if we aren't also
including the standard env.
There is also #46003 that was opened to allow custom env vars just for the
log groomers, which is probably a better answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
romsharon98 commented on PR #45483: URL: https://github.com/apache/airflow/pull/45483#issuecomment-2593349187 Can you add it to other logGroomer we have, and add tests [here](https://github.com/apache/airflow/blob/03349014513114f1eaa413a9831b0027e4fbfa67/tests/charts/log_groomer.py)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
mrestivill closed pull request #45483: Pass specific env vars to logGroomerSideCar URL: https://github.com/apache/airflow/pull/45483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass specific env vars to logGroomerSideCar [airflow]
boring-cyborg[bot] commented on PR #45483: URL: https://github.com/apache/airflow/pull/45483#issuecomment-2577612637 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
