Re: [PR] Pass workload to KE using command args instead of init container [airflow]
amoghrajesh merged PR #50448: URL: https://github.com/apache/airflow/pull/50448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass workload to KE using command args instead of init container [airflow]
boring-cyborg[bot] commented on PR #50448: URL: https://github.com/apache/airflow/pull/50448#issuecomment-2893407531 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass workload to KE using command args instead of init container [airflow]
amoghrajesh commented on PR #50448: URL: https://github.com/apache/airflow/pull/50448#issuecomment-2893409173 @davidsharp7 good work on this one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass workload to KE using command args instead of init container [airflow]
amoghrajesh commented on PR #50448: URL: https://github.com/apache/airflow/pull/50448#issuecomment-2893069617 @davidsharp7 no further need to rebase, i will merge it once its green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass workload to KE using command args instead of init container [airflow]
amoghrajesh commented on PR #50448: URL: https://github.com/apache/airflow/pull/50448#issuecomment-2889876602 > > Nice, i like how it turned out to be so simple. @davidsharp7 if you can run some dags with these changes, it would give me confidence to approve it. > > Are the various tests not enough? Would be happy to do it but my local Mac is spluttering. Actually yeah, the CI is running fine with integration tests, so we are good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pass workload to KE using command args instead of init container [airflow]
davidsharp7 commented on PR #50448: URL: https://github.com/apache/airflow/pull/50448#issuecomment-2888564906 > Nice, i like how it turned out to be so simple. @davidsharp7 if you can run some dags with these changes, it would give me confidence to approve it. Are the various tests not enough? Would be happy to do it but my local Mac is spluttering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
