Re: [PR] Refactor documentation modal component to use it for dag and task. [airflow]

[via GitHub]

pierrejeambrun merged PR #44863:
URL: https://github.com/apache/airflow/pull/44863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor documentation modal component to use it for dag and task. [airflow]

[via GitHub]

pierrejeambrun commented on code in PR #44863:
URL: https://github.com/apache/airflow/pull/44863#discussion_r1882398241


##
airflow/ui/src/components/DocumentationModal.tsx:
##
@@ -23,14 +23,21 @@ import Markdown from "react-markdown";
 
 import { Button, Dialog } from "src/components/ui";
 
-const DagDocumentation = ({ docMd }: { readonly docMd: string }) => {
+const DocumentationModal = ({
+  docMd,
+  isDag = false,

Review Comment:
   No strong opinion on that. (at least we don't have the confusion that 
`isDag=False` and it's a new entity that doesn't yet exist that is also not a 
task, more extensible, but really nit I don't mind)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor documentation modal component to use it for dag and task. [airflow]

[via GitHub]

pierrejeambrun commented on code in PR #44863:
URL: https://github.com/apache/airflow/pull/44863#discussion_r1882398241


##
airflow/ui/src/components/DocumentationModal.tsx:
##
@@ -23,14 +23,21 @@ import Markdown from "react-markdown";
 
 import { Button, Dialog } from "src/components/ui";
 
-const DagDocumentation = ({ docMd }: { readonly docMd: string }) => {
+const DocumentationModal = ({
+  docMd,
+  isDag = false,

Review Comment:
   No strong opinion on that. (at least we don't have the confusion that 
`isDag=False` and it's a new entity that doesn't yet exist that is also not a 
task, more extensible, but really nit I don't mind). Merging like this we can 
update if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor documentation modal component to use it for dag and task. [airflow]

[via GitHub]

tirkarthi commented on code in PR #44863:
URL: https://github.com/apache/airflow/pull/44863#discussion_r1881486816


##
airflow/ui/src/components/DocumentationModal.tsx:
##
@@ -23,14 +23,21 @@ import Markdown from "react-markdown";
 
 import { Button, Dialog } from "src/components/ui";
 
-const DagDocumentation = ({ docMd }: { readonly docMd: string }) => {
+const DocumentationModal = ({
+  docMd,
+  isDag = false,

Review Comment:
   Makes sense, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor documentation modal component to use it for dag and task. [airflow]

[via GitHub]

jscheffl commented on code in PR #44863:
URL: https://github.com/apache/airflow/pull/44863#discussion_r1881476776


##
airflow/ui/src/components/DocumentationModal.tsx:
##
@@ -23,14 +23,21 @@ import Markdown from "react-markdown";
 
 import { Button, Dialog } from "src/components/ui";
 
-const DagDocumentation = ({ docMd }: { readonly docMd: string }) => {
+const DocumentationModal = ({
+  docMd,
+  isDag = false,

Review Comment:
   Instead of making it boolean... atm it is used only in task and dag... would 
it make sense to rather pass a `readonly docType: string` as parameter and use 
this as `docType` directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org