Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


potiuk commented on PR #44489:
URL: https://github.com/apache/airflow/pull/44489#issuecomment-2508714744

   Uff :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


potiuk merged PR #44489:
URL: https://github.com/apache/airflow/pull/44489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


potiuk commented on PR #44489:
URL: https://github.com/apache/airflow/pull/44489#issuecomment-2508697656

   Variable too... I hate circular imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


shahar1 commented on PR #44489:
URL: https://github.com/apache/airflow/pull/44489#issuecomment-2508683233

   > Hopefully green now :)
   
   Not yet 😅 I was too optimistic


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


potiuk commented on PR #44489:
URL: https://github.com/apache/airflow/pull/44489#issuecomment-2508674290

   Hopefully green now :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


potiuk commented on PR #44489:
URL: https://github.com/apache/airflow/pull/44489#issuecomment-2508674064

   One of those I want to get rid in airflow 3 by explicit rather than implicit 
initialization via "airflow.__init__". 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


potiuk commented on PR #44489:
URL: https://github.com/apache/airflow/pull/44489#issuecomment-2508671892

   Ah... Our favorite:  `ImportError: cannot import name 'MetastoreBackend' 
from partially initialized module 'airflow.secrets.metastore' (most likely due 
to a circular import) (/opt/airflow/airflow/secrets/metastore.py)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove internal_api_call from airflow.secrets.metastore [airflow]

2024-11-29 Thread via GitHub


shahar1 commented on PR #44489:
URL: https://github.com/apache/airflow/pull/44489#issuecomment-2508668495

   Tests are 🔴


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org