Re: [PR] Remove password extra - nothing uses those deps [airflow]
vincbeck commented on code in PR #48027: URL: https://github.com/apache/airflow/pull/48027#discussion_r2006194058 ## newsfragments/48027.significant.rst: ## @@ -0,0 +1,14 @@ +``password`` extra has been removed Review Comment: Sounds good. Then we should select "Dependency changes" ## newsfragments/48027.significant.rst: ## @@ -0,0 +1,14 @@ +``password`` extra has been removed + +Nothing is using the dependencies that are installed in the ``password`` extra (``bcrypt`` and ``flask-bcrypt``), so the extra has been removed. + +* Types of change + + * [ ] Dag changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency changes Review Comment: ```suggestion * [x] Dependency changes ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove password extra - nothing uses those deps [airflow]
eladkal commented on PR #48027: URL: https://github.com/apache/airflow/pull/48027#issuecomment-2741303213 > We no longer need this extra - nothing uses it. I thought this is being used by `basic_auth` which we moved to fab. should we move this extra to fab or just remove it entirely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove password extra - nothing uses those deps [airflow]
jedcunningham commented on code in PR #48027: URL: https://github.com/apache/airflow/pull/48027#discussion_r2006298780 ## newsfragments/48027.significant.rst: ## @@ -0,0 +1,14 @@ +``password`` extra has been removed Review Comment: Idk, it's more of a dependency removal, it's doesn't break anything. You can still ask for the extra too, and pip/uv will just warn 🤷. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove password extra - nothing uses those deps [airflow]
jedcunningham merged PR #48027: URL: https://github.com/apache/airflow/pull/48027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove password extra - nothing uses those deps [airflow]
potiuk commented on code in PR #48027: URL: https://github.com/apache/airflow/pull/48027#discussion_r2008832738 ## newsfragments/48027.significant.rst: ## @@ -0,0 +1,14 @@ +``password`` extra has been removed + +Nothing is using the dependencies that are installed in the ``password`` extra (``bcrypt`` and ``flask-bcrypt``), so the extra has been removed. + +* Types of change + + * [ ] Dag changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency changes Review Comment: Yeah. Let's make into a dependency change :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove password extra - nothing uses those deps [airflow]
jedcunningham commented on PR #48027: URL: https://github.com/apache/airflow/pull/48027#issuecomment-2741447254 > > We no longer need this extra - nothing uses it. > > I thought this is being used by `basic_auth` which we moved to fab. should we move this extra to fab or just remove it entirely? I don't see it being used in Airflow 2 even :) I see it being used in 1.10 though. Am I missing a use somewhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove password extra - nothing uses those deps [airflow]
jedcunningham commented on code in PR #48027: URL: https://github.com/apache/airflow/pull/48027#discussion_r2006185320 ## newsfragments/48027.significant.rst: ## @@ -0,0 +1,14 @@ +``password`` extra has been removed Review Comment: I'd say this is a gray area. Figured it doesn't hurt to at least track it so we can decide as we are writing the release notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove password extra - nothing uses those deps [airflow]
vincbeck commented on code in PR #48027: URL: https://github.com/apache/airflow/pull/48027#discussion_r2006167211 ## newsfragments/48027.significant.rst: ## @@ -0,0 +1,14 @@ +``password`` extra has been removed Review Comment: Removal of a dependency is a breaking change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
