Re: [PR] Simplify TaskSDK's CommsDecoder interface [airflow]
ashb commented on PR #45927:
URL: https://github.com/apache/airflow/pull/45927#issuecomment-2607273340
I've changed my mind on this -- we should change everything to always have a
resposne, even if that is `{"ok": true}` so that we can catch and propagate
exceptions to the Task code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Simplify TaskSDK's CommsDecoder interface [airflow]
ashb commented on PR #45927: URL: https://github.com/apache/airflow/pull/45927#issuecomment-2607274543 I'm parking this change for now and will revisit it for fuller exception handling/propagation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Simplify TaskSDK's CommsDecoder interface [airflow]
ashb closed pull request #45927: Simplify TaskSDK's CommsDecoder interface URL: https://github.com/apache/airflow/pull/45927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Simplify TaskSDK's CommsDecoder interface [airflow]
amoghrajesh commented on code in PR #45927: URL: https://github.com/apache/airflow/pull/45927#discussion_r1925225306 ## task_sdk/src/airflow/sdk/execution_time/comms.py: ## @@ -265,7 +269,7 @@ class PutVariable(BaseModel): type: Literal["PutVariable"] = "PutVariable" Review Comment: We should add for this one too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
