Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W merged PR #45678: URL: https://github.com/apache/airflow/pull/45678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2611462421 I think we already have enough checks for this one. Merge it. Thanks for everyone's help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2606928318 [newsfragment_summary.csv](https://github.com/user-attachments/files/18504249/newsfragment_summary.csv) I just implemented a script to check the format of existing news fragments and make a quick summary. Here's what I got. For simplicity, I'll probably create another PR for that script. But would be nice if anyone could take a look and check whether this summary helps cc @kaxil @vikramkoka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
bugraoz93 commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2599756678 Thank you for all the effort! I have reviewed mine. It looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1920936787 ## newsfragments/template.significant.rst: ## @@ -3,20 +3,29 @@ .. Provide additional contextual information .. Check the type of change that applies to this change +.. Dag changes: requires users to change their dag code +.. Config changes: requires users to change their airflow config +.. API changes: requires users to change their Airflow REST API calls +.. API changes: requires users to change their Airflow usage Review Comment: fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1920936557 ## newsfragments/template.significant.rst: ## @@ -3,20 +3,29 @@ .. Provide additional contextual information .. Check the type of change that applies to this change +.. Dag changes: requires users to change their dag code +.. Config changes: requires users to change their airflow config +.. API changes: requires users to change their Airflow REST API calls +.. API changes: requires users to change their Airflow usage Review Comment: Ah yes and I miss CLI in the description as well 🤦♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
jscheffl commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1920812007 ## newsfragments/template.significant.rst: ## @@ -3,20 +3,29 @@ .. Provide additional contextual information .. Check the type of change that applies to this change +.. Dag changes: requires users to change their dag code +.. Config changes: requires users to change their airflow config +.. API changes: requires users to change their Airflow REST API calls +.. API changes: requires users to change their Airflow usage Review Comment: Here is a small Uuups, I assume the second shouldbe CLI? ```suggestion .. API changes: requires users to change their Airflow REST API calls .. CLI changes: requires users to change their Airflow usage ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2598541991 > I'd be happy for an explanation about what each "type of change" covers. In my case, I removed a a deprecated `TriggerRule` and it was considered only as a "DAG change". Should it be marked also as a "Code interface change" and/or "Behaviour changes" (due to the interface breaking)? I tried to add some descriptions based on my understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
shahar1 commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2597548885 I'd be happy for an explanation what each "type of change" covers. In my case, I removed a a deprecated `TriggerRule` and it was considered only as a "DAG change". Should it be marked also as a "Code interface change" and/or "Behaviour changes" (due to the interface breaking)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2597426182 I'll keep it open for around 1 week so that everyone can take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
vatsrahul1001 commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2597383962 Thanks @Lee-W. I have reviewed my changes newsfragments/44533.significant.rst. LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1919442003 ## newsfragments/40029.significant.rst: ## @@ -1 +1,18 @@ -Removed deprecated ``allow_raw_html_descriptions`` option from UI Trigger forms. +Removed deprecated airflow configuration ``webserver.allow_raw_html_descriptions`` from UI Trigger forms. + +* Types of change + + * [ ] DAG changes + * [x] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [x] Plugin changes Review Comment: docs(newsfragmenst): update 40029 change type ## newsfragments/40029.significant.rst: ## @@ -1 +1,18 @@ -Removed deprecated ``allow_raw_html_descriptions`` option from UI Trigger forms. +Removed deprecated airflow configuration ``webserver.allow_raw_html_descriptions`` from UI Trigger forms. + +* Types of change + + * [ ] DAG changes + * [x] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [x] Plugin changes Review Comment: docs(newsfragmenst): update 40029 change type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2597252889 > A bit of "magic" scripting and I generated list of PRs + authors in a checklist form - this should make it easier to know who should review what and keep track of it. yep, it's super helpful! just updated it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
jscheffl commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1919137132 ## newsfragments/43612.significant.rst: ## @@ -6,3 +6,14 @@ AIRFLOW__STANDARD__VENV_INSTALL_METHOD option. The possible values are: - ``auto``: Automatically select, use ``uv`` if available, otherwise use ``pip``. - ``pip``: Use pip to install the virtual environment. - ``uv``: Use uv to install the virtual environment. Must be available in environment PATH. + +* Types of change + + * [ ] DAG changes + * [ ] Config changes Review Comment: It adds a new config option and is mainly influenc-ablein a DAG - does it therefore be applicable for these two categories? Or does it mean the user needs/is forced to revise and check existing DAGs/configs? (This is just a new feature) ```suggestion * [x] DAG changes * [x] Config changes ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
jscheffl commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1919134149 ## newsfragments/41808.significant.rst: ## @@ -6,3 +6,14 @@ Removed methods: - ``find_for_task_instance()`` Note: there are no replacements. Direct access to DB is discouraged and will not be possible in Airflow 3 for tasks. The public REST API is the future way to interact with Airflow + +* Types of change + + * [x] DAG changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + * [ ] Code interface change Review Comment: This is usually not used within a DAG, only in custom code or plugins. I assume. ```suggestion * [ ] DAG changes * [ ] Config changes * [ ] API changes * [ ] CLI changes * [ ] Behaviour changes * [ ] Plugin changes * [ ] Dependency change * [x] Code interface change ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
jscheffl commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1919098582 ## newsfragments/41758.significant.rst: ## @@ -10,3 +10,28 @@ Removed deprecated functions and modules from ``airflow.www`` module. ``airflow.utils.log.secrets_masker.get_sensitive_variables_fields`` instead. - Removed the method ``should_hide_value_for_key()`` from ``airflow.www.utils``: Please use ``airflow.utils.log.secrets_masker.should_hide_value_for_key`` instead. + +* Types of change + + * [ ] DAG changes + * [x] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + * [ ] Code interface change Review Comment: I would say due to deprecations if people use it in private code it is a non-public API cleanup. ```suggestion * [x] Code interface change ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
jscheffl commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1919103637 ## newsfragments/41774.significant.rst: ## @@ -10,3 +10,14 @@ Removed a set of deprecations in ``DAG`` from ``airflow.models``. - Removed implicit support to call ``create_dagrun()`` without data interval. - Removed support for deprecated parameter ``concurrency`` in ``DagModel``. - Removed support for ``datetime`` in ``DagModel.calculate_dagrun_date_fields``. Use ``DataInterval``. + +* Types of change + + * [x] DAG changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + * [ ] Code interface change Review Comment: Same as above. Would say that API for internal code is changing, even it was not public marked before ```suggestion * [x] Code interface change ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
jscheffl commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1919083928 ## newsfragments/40029.significant.rst: ## @@ -1 +1,18 @@ -Removed deprecated ``allow_raw_html_descriptions`` option from UI Trigger forms. +Removed deprecated airflow configuration ``webserver.allow_raw_html_descriptions`` from UI Trigger forms. + +* Types of change + + * [ ] DAG changes + * [x] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [x] Plugin changes Review Comment: Actually this was not changing anything on plugins. Just the raw HTML was a hack like plugins to be able to inject JavaScript to the forms... beneficial as well as malicious one. ```suggestion * [ ] Plugin changes ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
potiuk commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2596432207 @Lee-W -> If you want - you can move the list up from the comment I made to the description of the PR - to keep it at the top. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
potiuk commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2596425866 reviewed mine and marked them in the list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
gopidesupavan commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2596422458 > A bit of "magic" scripting and I generated list of PRs + authors in a checklist form - this should make it easier to know who should review what and keep track of it. Super 😍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
potiuk commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2596421341 A bit of "magic" scripting and I generated list of PRs + authors in a checklist form - this should make it easier to know who should review what and keep track of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
potiuk commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2596418278 - [ ] #41453 @uranusjr - [ ] #40029 @jscheffl - [ ] #40931 @dirrao - [ ] #41096 @dirrao - [ ] #41348 @Lee-W - [ ] #41366 @jedcunningham - [ ] #41367 @jedcunningham - [ ] #41368 @jedcunningham - [ ] #41390 @kaxil - [ ] #41391 @kaxil - [ ] #41435 @vincbeck - [ ] #41394 @kaxil - [ ] #41395 @kaxil - [ ] #41695 @Avihais12344 - [ ] #41434 @vincbeck - [ ] #41440 @dstandish - [ ] #41453 @uranusjr - [ ] #41496 @dirrao - [ ] #41520 @dirrao - [ ] #41533 @gopidesupavan - [ ] #41539 @dirrao - [ ] #41550 @dirrao - [ ] #41552 @dirrao - [ ] #41579 @dirrao - [ ] #41609 @dirrao - [ ] #41635 @dirrao - [ ] #41642 @dirrao - [ ] #41663 @dirrao - [ ] #41693 @dirrao - [ ] #41708 @dirrao - [ ] #41733 @jscheffl - [ ] #41735 @jscheffl - [ ] #41736 @jscheffl - [ ] #41737 @jscheffl - [ ] #41739 @dirrao - [ ] #41748 @dirrao - [ ] #41758 @jscheffl - [ ] #41761 @jscheffl - [ ] #41762 @jscheffl - [ ] #41774 @jscheffl - [ ] #41776 @jscheffl - [ ] #41778 @jscheffl - [ ] #41779 @jscheffl - [ ] #41780 @jscheffl - [ ] #41784 @dirrao - [ ] #41808 @jscheffl - [ ] #41857 @pierrejeambrun - [ ] #41910 @dirrao - [ ] #41964 @jedcunningham - [ ] #41975 @dirrao - [ ] #42023 @Lee-W - [ ] #42042 @vincbeck - [ ] #42066 @topherinternational - [ ] #42060 @dirrao - [ ] #42088 @dirrao - [ ] #42100 @dirrao - [ ] #42126 @dirrao - [ ] #42129 @dirrao - [ ] #42137 @potiuk - [ ] #42280 @vincbeck - [ ] #42285 @ferruzzi - [ ] #42343 @uranusjr - [ ] #42404 @sunank200 - [ ] #42436 @uranusjr - [ ] #42548 @dstandish - [ ] #42579 @Lee-W - [ ] #42640 @dirrao - [ ] #42647 @dirrao - [ ] #42658 @dirrao - [ ] #42660 @dirrao - [ ] #42766 @jscheffl - [ ] #42776 @dirrao - [ ] #43564 @kaxil - [ ] #43067 @dstandish - [ ] #43073 @Lee-W - [ ] #43096 @vincbeck - [ ] #43102 @bugraoz93 - [ ] #43183 @dstandish - [ ] #43289 @kaxil - [ ] #43291 @kaxil - [ ] #44741 @shahar1 - [ ] #43490 @kaxil - [ ] #43530 @kaxil - [ ] #43533 @kaxil - [ ] #43562 @kaxil - [ ] #43568 @potiuk - [ ] #43611 @jscheffl - [ ] #43612 @jscheffl - [ ] #43774 @Lee-W - [ ] #43902 @sunank200 - [ ] #43915 @uranusjr - [ ] #43943 @ashb - [ ] #43949 @ephraimbuddy - [ ] #43975 @kaxil - [ ] #44080 @jedcunningham - [ ] #44475 @Lee-W - [ ] #44533 @vatsrahul1001 - [ ] #44706 @jedcunningham - [ ] #44820 @kaxil - [ ] #45065 @jedcunningham - [ ] #45530 @jscheffl - [ ] #45694 @kaxil - [ ] #43551 @ashb - [ ] #45009 @vincbeck - [ ] #44378 @Lee-W -[ ] #43291 @kaxil -[ ] #44741 @shahar1 -[ ] #43490 @kaxil -[ ] #43530 @kaxil -[ ] #43533 @kaxil -[ ] #43562 @kaxil -[ ] #43568 @potiuk -[ ] #43611 @jscheffl -[ ] #43612 @jscheffl -[ ] #43774 @Lee-W -[ ] #43902 @sunank200 -[ ] #43915 @uranusjr -[ ] #43943 @ashb -[ ] #43949 @ephraimbuddy -[ ] #43975 @kaxil -[ ] #44080 @jedcunningham -[ ] #44475 @Lee-W -[ ] #44533 @vatsrahul1001 -[ ] #44706 @jedcunningham -[ ] #44820 @kaxil -[ ] #45065 @jedcunningham -[ ] #45530 @jscheffl -[ ] #45694 @kaxil -[ ] #43551 @ashb -[ ] #45009 @vincbeck -[ ] #44378 @Lee-W -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
vincbeck commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1918623223 ## newsfragments/42042.significant.rst: ## @@ -1 +1,12 @@ Removed ``is_active`` property from ``BaseUser``. This property is longer used. + +* Types of change + + * [ ] DAG changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + * [ ] Code interface change Review Comment: ```suggestion * [x] Code interface change ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1918091276 ## newsfragments/aip-79.significant.rst: ## @@ -13,3 +13,13 @@ As part of this change the following breaking changes have occurred: - The property ``security_manager`` has been removed from the interface - The method ``filter_permitted_menu_items`` is now abstract and must be implemented + +* Types of change Review Comment: Sounds like a great idea! Let me update it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
Lee-W commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1918087455 ## newsfragments/41391.significant.rst: ## @@ -1,5 +1,22 @@ -**Breaking Change** - The ``airflow.providers.standard.sensors.external_task.ExternalTaskSensorLink`` class has been removed. + This class was deprecated and is no longer available. Users should now use the ``airflow.providers.standard.sensors.external_task.ExternalDagLink`` class directly. + +* Types of change + + * [x] DAG changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + +* Migration rules needed + + * ruff + +* AIR302 + + * [x] ``airflow.sensors.external_task.ExternalTaskSensorLink`` → ``airflow.sensors.external_task.ExternalDagLin`` Review Comment: Thanks! updated ## newsfragments/41533.significant.rst: ## @@ -24,3 +23,22 @@ Example update: .. code-block:: python connection_by_conn_id = LocalFilesystemBackend().get_connection(conn_id="conn_id") + +* Types of change + + * [x] DAG changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + +* Migration rules needed + + * ruff + +* AIR302 + + * [x] ``airflow.secrets.local_filesystem.load_connections`` → ``airflow.secrets.local_filesystem.load_connections_dict`` + * [x] ``airflow.secrets.local_filesystem.get_connection`` → ``airflow.secrets.local_filesystem.load_connections_dict`` Review Comment: Thanks! updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
gopidesupavan commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1917144586 ## newsfragments/41533.significant.rst: ## @@ -24,3 +23,22 @@ Example update: .. code-block:: python connection_by_conn_id = LocalFilesystemBackend().get_connection(conn_id="conn_id") + +* Types of change + + * [x] DAG changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + +* Migration rules needed + + * ruff + +* AIR302 + + * [x] ``airflow.secrets.local_filesystem.load_connections`` → ``airflow.secrets.local_filesystem.load_connections_dict`` + * [x] ``airflow.secrets.local_filesystem.get_connection`` → ``airflow.secrets.local_filesystem.load_connections_dict`` Review Comment: ```suggestion * [x] ``airflow.secrets.local_filesystem.LocalFilesystemBackend.get_connections`` → ``airflow.secrets.local_filesystem.LocalFilesystemBackend.get_connection`` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
kaxil commented on PR #45678: URL: https://github.com/apache/airflow/pull/45678#issuecomment-2593608649 #protm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
kaxil commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1917116914 ## newsfragments/41391.significant.rst: ## @@ -1,5 +1,22 @@ -**Breaking Change** - The ``airflow.providers.standard.sensors.external_task.ExternalTaskSensorLink`` class has been removed. + This class was deprecated and is no longer available. Users should now use the ``airflow.providers.standard.sensors.external_task.ExternalDagLink`` class directly. + +* Types of change + + * [x] DAG changes + * [ ] Config changes + * [ ] API changes + * [ ] CLI changes + * [ ] Behaviour changes + * [ ] Plugin changes + * [ ] Dependency change + +* Migration rules needed + + * ruff + +* AIR302 + + * [x] ``airflow.sensors.external_task.ExternalTaskSensorLink`` → ``airflow.sensors.external_task.ExternalDagLin`` Review Comment: ```suggestion * [x] ``airflow.sensors.external_task.ExternalTaskSensorLink`` → ``airflow.sensors.external_task.ExternalDagLink`` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update existing significant newsfragments with the later introduced template format [airflow]
vincbeck commented on code in PR #45678: URL: https://github.com/apache/airflow/pull/45678#discussion_r1916709417 ## newsfragments/aip-79.significant.rst: ## @@ -13,3 +13,13 @@ As part of this change the following breaking changes have occurred: - The property ``security_manager`` has been removed from the interface - The method ``filter_permitted_menu_items`` is now abstract and must be implemented + +* Types of change Review Comment: Should we add a type for this use case? I guess there must be several cases where an interface that user might implement have breaking changes. Something like "Code interface change". Users who have a custom auth manager or custom executor and implement the auth manager/executor interface will face breaking change. Having this category might help them. I dont expect many users doing it but I am pretty sure there are some. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
