Re: [PR] Upgrade `flask-appbuilder` to 4.6.3 in FAB provider [airflow]
vincbeck merged PR #50513: URL: https://github.com/apache/airflow/pull/50513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade `flask-appbuilder` to 4.6.3 in FAB provider [airflow]
vincbeck commented on PR #50513: URL: https://github.com/apache/airflow/pull/50513#issuecomment-2877163447 > > You are correct, we are not using the groups feature. Though, I updated the models using new tables such as `ab_user_group` and `ab_group` without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not sure when they have been created but I am sure I have not modified/created any migration > > Hmm.. Maybe Fab auto-migrates the models ? Maybe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade `flask-appbuilder` to 4.6.3 in FAB provider [airflow]
vincbeck commented on PR #50513: URL: https://github.com/apache/airflow/pull/50513#issuecomment-2877179756 > > > You are correct, we are not using the groups feature. Though, I updated the models using new tables such as `ab_user_group` and `ab_group` without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not sure when they have been created but I am sure I have not modified/created any migration > > > > > > Hmm.. Maybe Fab auto-migrates the models ? > > Maybe But on the other end it makes sense, we do have migration defining FAB related tables. FAB handles it itself. When you reset the DB, the tables are automatically created even though we do not have migration for it. Same thing applies here with the new tables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade `flask-appbuilder` to 4.6.3 in FAB provider [airflow]
potiuk commented on PR #50513: URL: https://github.com/apache/airflow/pull/50513#issuecomment-2877133984 > You are correct, we are not using the groups feature. Though, I updated the models using new tables such as `ab_user_group` and `ab_group` without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not sure when they have been created but I am sure I have not modified/created any migration Hmm.. Maybe Fab auto-migrates the models ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade `flask-appbuilder` to 4.6.3 in FAB provider [airflow]
vincbeck commented on PR #50513: URL: https://github.com/apache/airflow/pull/50513#issuecomment-2877017799 > Looks good. Do I understand correctly, that we are adding the models but NOT running the migration for FAB and not creating the models - and we are not using the "Groups" feature at all ? Or they will be created automatically somehow? You are correct, we are not using the groups feature. Though, I updated the models using new tables such as `ab_user_group` and `ab_group` without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not when they have been created but I am sure I have not modified/created any migration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
