Re: [PR] Version cap fastapi due to is_coroutine changes in 0.123.5 [airflow]

2025-12-03 Thread via GitHub


bugraoz93 commented on PR #58980:
URL: https://github.com/apache/airflow/pull/58980#issuecomment-3608301151

   Great to hear the release hasn't been impacted! Thanks @tirkarthi for 
following up! Hopefully, it will be fixed for the next wave :crossed_fingers: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Version cap fastapi due to is_coroutine changes in 0.123.5 [airflow]

2025-12-02 Thread via GitHub


ephraimbuddy commented on PR #58980:
URL: https://github.com/apache/airflow/pull/58980#issuecomment-3605391830

   Airflow 3.1 is not affected. it has fastapi version limit of 118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Version cap fastapi due to is_coroutine changes in 0.123.5 [airflow]

2025-12-02 Thread via GitHub


amoghrajesh commented on PR #58980:
URL: https://github.com/apache/airflow/pull/58980#issuecomment-3605314035

   @uranusjr here's an example run that failed: 
https://github.com/apache/airflow/actions/runs/19874997189/job/56960727172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Version cap fastapi due to is_coroutine changes in 0.123.5 [airflow]

2025-12-02 Thread via GitHub


uranusjr commented on PR #58980:
URL: https://github.com/apache/airflow/pull/58980#issuecomment-3605306819

   What’s the error before this change? I can probably look into the root cause.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Version cap fastapi due to is_coroutine changes in 0.123.5 [airflow]

2025-12-02 Thread via GitHub


potiuk commented on PR #58980:
URL: https://github.com/apache/airflow/pull/58980#issuecomment-3604437627

   Merged - as it seems to work now. Unfortunately the way how Fast API issues 
are designed - we do not have a way to create an issue there so I think someonw 
with more fastapi knowledge will have to investigate if that's our issue or 
FastaPI.
   
   cc: @pierrejeambrun @ephraimbuddy -> this one will likely break 3.1.4 
release, so you might also need to cherry-pick that one (unless there is a 
comment from FastAPI team.
   
   I am mostly **not** available tomorrow to pick that one up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Version cap fastapi due to is_coroutine changes in 0.123.5 [airflow]

2025-12-02 Thread via GitHub


github-actions[bot] commented on PR #58980:
URL: https://github.com/apache/airflow/pull/58980#issuecomment-3604433459

   ### Backport failed to create: v3-1-test. View the failure log  Run details 

   
   
   
   Status
   Branch
   Result
   
   
   ❌
   v3-1-test
   https://github.com/apache/airflow/commit/fe99a32f27d43147840094a74b56e1045cb2f032";>
   
   
   
   You can attempt to backport this manually by running:
   
   ```bash
   cherry_picker fe99a32 v3-1-test
   ```
   
   This should apply the commit to the v3-1-test branch and leave the commit in 
conflict state marking
   the files that need manual conflict resolution.
   
   After you have resolved the conflicts, you can continue the backport process 
by running:
   
   ```bash
   cherry_picker --continue
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Version cap fastapi due to is_coroutine changes in 0.123.5 [airflow]

2025-12-02 Thread via GitHub


potiuk merged PR #58980:
URL: https://github.com/apache/airflow/pull/58980


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]