Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
pierrejeambrun merged PR #51146: URL: https://github.com/apache/airflow/pull/51146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-3027602951 Everything that was requested has been addressed. Is there anything else needed for this PR to be merged? @pierrejeambrun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
pierrejeambrun commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-310249 'i18next-http-backend' is likely missing in your node modules. How are you trying to run the UI. Did you refreshed the dependencies (yarn install). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on PR #51146:
URL: https://github.com/apache/airflow/pull/51146#issuecomment-2999777980
Hi, thanks for the clarification!
That makes sense good to know the unnecessary requests are already being
bypassed in the setup.
However, I’m still running into an issue after rebasing. When I try to run
the frontend tests, I get the following error:
Error: Failed to resolve import "i18next-http-backend" from
"src/i18n/config.ts". Does the file exist?
Plugin: vite:import-analysis
File:
/root/documentos/PIC/airflow/airflow-core/src/airflow/ui/src/i18n/config.ts:21:20
18 | */ import i18n from "i18next";
19 | import LanguageDetector from "i18next-browser-languagedetector";
20 | import Backend from "i18next-http-backend";
| ^
21 | import { initReactI18next } from "react-i18next";
Do you have any idea what might be causing this? It seems like the module
isn't being resolved correctly after the rebase.
Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-3000385907 Now I’m hitting another problem when the pre-commit runs. It seems to fail during the TypeScript check with the following error: src/pages/Error.tsx:45:29 - error TS2339: Property 'env' does not exist on type 'ImportMeta'. 45 const isDev = import.meta.env.DEV; ~~~ This happens even though I’m not touching that file. Looks like the internal ts_compile_lint_ui.py script compiles a temporary tsconfig.json, and it might not be picking up the proper Vite type declarations? Let me know if this is something I should fix on my end or if the pre-commit script needs an adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-3000158744 Thanks! You're right . I hadn't run yarn install after the rebase. Just did it now and that fixed the issue. Appreciate the quick help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
guan404ming commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-2994288706 Hi, thanks for bringing this up. This is actually expected behavior. During testing, a few unnecessary requests may still be triggered. However, they have already been bypassed in the setup and should not interfere with the tests. The bypass logic is handled in `airflow-core/src/airflow/ui/testSetup.ts`. If you're still seeing fetch errors that cause test failures, please let me know as there might be something else going on. Feel free to ask more if there is anything need clarification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-2994311500 Hi @guan404ming , thanks for the explanation! I'm still having trouble getting the tests to progress. The mocked logs don't seem to be received the fetch call that should retrieve the logs isn't returning the mocked data, which causes the test to fail. Is there anything I need to do before running pnpm test -t "Display task log content on click" to ensure the mock setup works correctly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-2993050624 Hi, I'm having some trouble running the UI tests. I'm following the instructions in the runner and using pnpm test, but when I try to render a component like this: I'm not getting the expected mocks. instead, I get a fetch error: stderr | Fetch.onError (file:/root/documentos/PIC/airflow/airflow-core/src/airflow/ui/node_modules/.pnpm/[email protected]/node_modules/happy-dom/src/fetch/Fetch.ts:668:37) Error: connect ECONNREFUSED 127.0.0.1:3000 at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1555:16) { errno: -111, code: 'ECONNREFUSED', syscall: 'connect', address: '127.0.0.1', port: 3000 } It seems like the tests are trying to make a real network request instead of using mocks. Any idea what might be causing this or how I can properly mock the backend for this route? Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
guan404ming commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2157637990
##
airflow-core/src/airflow/ui/src/queries/useLogs.tsx:
##
@@ -95,40 +94,72 @@ const parseLogs = ({
return { data, warning };
}
- // TODO: Add support for nested groups
-
- parsedLines = parsedLines.map((line) => {
-const text = innerText(line);
-
-if (text.includes("::group::") && !startGroup) {
- startGroup = true;
- groupName = text.split("::group::")[1] as string;
-} else if (text.includes("::endgroup::")) {
- startGroup = false;
- const group = (
-
-
-
- {groupName}
-
-
- {groupLines}
-
- );
-
- groupLines = [];
-
- return group;
-}
+ parsedLines = (() => {
+type Group = { level: number; lines: Array; name: string
};
+const groupStack: Array = [];
+const result: Array = [];
+
+parsedLines.forEach((line) => {
+ const text = innerText(line);
+
+ if (text.includes("::group::")) {
+const groupName = text.split("::group::")[1] as string;
+
+groupStack.push({ level: groupStack.length, lines: [], name: groupName
});
+
+return;
+ }
-if (startGroup) {
- groupLines.push(line);
+ if (text.includes("::endgroup::")) {
+const finishedGroup = groupStack.pop();
+
+if (finishedGroup) {
+ const groupElement = (
+
+
Review Comment:
```suggestion
```
to use [chakra factory](https://chakra-ui.com/docs/styling/chakra-factory)
could preserve consistency and get better support for RTL lang
##
airflow-core/src/airflow/ui/src/queries/useLogs.tsx:
##
@@ -95,40 +94,72 @@ const parseLogs = ({
return { data, warning };
}
- // TODO: Add support for nested groups
-
- parsedLines = parsedLines.map((line) => {
-const text = innerText(line);
-
-if (text.includes("::group::") && !startGroup) {
- startGroup = true;
- groupName = text.split("::group::")[1] as string;
-} else if (text.includes("::endgroup::")) {
- startGroup = false;
- const group = (
-
-
-
- {groupName}
-
-
- {groupLines}
-
- );
-
- groupLines = [];
-
- return group;
-}
+ parsedLines = (() => {
+type Group = { level: number; lines: Array; name: string
};
+const groupStack: Array = [];
+const result: Array = [];
+
+parsedLines.forEach((line) => {
+ const text = innerText(line);
+
+ if (text.includes("::group::")) {
+const groupName = text.split("::group::")[1] as string;
+
+groupStack.push({ level: groupStack.length, lines: [], name: groupName
});
+
+return;
+ }
-if (startGroup) {
- groupLines.push(line);
+ if (text.includes("::endgroup::")) {
+const finishedGroup = groupStack.pop();
+
+if (finishedGroup) {
+ const groupElement = (
+
+
+
Review Comment:
```suggestion
```
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
pierrejeambrun commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2152398310
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -178,20 +183,57 @@ export const TaskLogHeader = ({
) : undefined}
-
+
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
pierrejeambrun commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2152396660
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -178,20 +183,57 @@ export const TaskLogHeader = ({
) : undefined}
-
+
{wrap ? "Unwrap" : "Wrap"}
+
Review Comment:
has been done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
pierrejeambrun commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2152393805
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -178,20 +183,57 @@ export const TaskLogHeader = ({
) : undefined}
-
+
{wrap ? "Unwrap" : "Wrap"}
+
+
+
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
pierrejeambrun commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2144977991
##
airflow-core/src/airflow/ui/src/i18n/locales/de/common.json:
##
@@ -63,6 +63,11 @@
},
"duration": "Laufzeit",
"endDate": "Enddatum",
+ "expand": {
+"collapse": "Einklappen",
+"expand": "Erweitern",
+"tooltip": "Drücken Sie {{hotkey}}, um zu erweitern"
+ },
Review Comment:
Just fill the english translations (because those are the one we can
approve) and let the other translation owners update their respective files in
follow up PRs.
##
airflow-core/src/airflow/ui/src/queries/useLogs.tsx:
##
@@ -95,40 +94,72 @@ const parseLogs = ({
return { data, warning };
}
- // TODO: Add support for nested groups
-
- parsedLines = parsedLines.map((line) => {
-const text = innerText(line);
-
-if (text.includes("::group::") && !startGroup) {
- startGroup = true;
- groupName = text.split("::group::")[1] as string;
-} else if (text.includes("::endgroup::")) {
- startGroup = false;
- const group = (
-
-
-
- {groupName}
-
-
- {groupLines}
-
- );
-
- groupLines = [];
-
- return group;
-}
+ parsedLines = (() => {
+type Group = { level: number; lines: Array; name: string
};
+const groupStack: Array = [];
+const result: Array = [];
+
+parsedLines.forEach((line) => {
+ const text = innerText(line);
+
+ if (text.includes("::group::")) {
+const groupName = text.split("::group::")[1] as string;
+
+groupStack.push({ level: groupStack.length, lines: [], name: groupName
});
+
+return;
+ }
-if (startGroup) {
- groupLines.push(line);
+ if (text.includes("::endgroup::")) {
+const finishedGroup = groupStack.pop();
+
+if (finishedGroup) {
+ const groupElement = (
+
+
+
+
+{finishedGroup.name}
+
+
+{finishedGroup.lines}
+
+
+ );
+
+ const lastGroup = groupStack[groupStack.length - 1];
+
+ if (groupStack.length > 0 && lastGroup) {
+lastGroup.lines.push(groupElement);
+ } else {
+result.push(groupElement);
+ }
+}
- return undefined;
-} else {
- return line;
+return;
+ }
+
+ if (groupStack.length > 0 && groupStack[groupStack.length - 1]) {
+groupStack[groupStack.length - 1]?.lines.push(line);
+ } else {
+result.push(line);
+ }
+});
+
+while (groupStack.length > 0) {
+ const unfinished = groupStack.pop();
+
+ if (unfinished) {
+result.push(
+
Review Comment:
Same
##
airflow-core/src/airflow/ui/src/queries/useLogs.tsx:
##
@@ -95,40 +94,72 @@ const parseLogs = ({
return { data, warning };
}
- // TODO: Add support for nested groups
-
- parsedLines = parsedLines.map((line) => {
-const text = innerText(line);
-
-if (text.includes("::group::") && !startGroup) {
- startGroup = true;
- groupName = text.split("::group::")[1] as string;
-} else if (text.includes("::endgroup::")) {
- startGroup = false;
- const group = (
-
-
-
- {groupName}
-
-
- {groupLines}
-
- );
-
- groupLines = [];
-
- return group;
-}
+ parsedLines = (() => {
+type Group = { level: number; lines: Array; name: string
};
+const groupStack: Array = [];
+const result: Array = [];
+
+parsedLines.forEach((line) => {
+ const text = innerText(line);
+
+ if (text.includes("::group::")) {
+const groupName = text.split("::group::")[1] as string;
+
+groupStack.push({ level: groupStack.length, lines: [], name: groupName
});
+
+return;
+ }
-if (startGroup) {
- groupLines.push(line);
+ if (text.includes("::endgroup::")) {
+const finishedGroup = groupStack.pop();
+
+if (finishedGroup) {
+ const groupElement = (
+
Review Comment:
Don't push a random number on the key, that defeats the purpose keys and
react diffing between renders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
bbovenzi commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-2967704446 I would rebase after https://github.com/apache/airflow/pull/51666 is merged. And there shouldn't be too many translations you need to add. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
bbovenzi commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2143236170
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx:
##
@@ -94,17 +100,19 @@ export const Logs = () => {
return (
{showExternalLogRedirect && externalLogName && taskInstance ? (
tryNumber === undefined ? (
- No try number
+ {translate("No try number")}
Review Comment:
Let's rebase and use the correct translate here.
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -178,20 +183,57 @@ export const TaskLogHeader = ({
) : undefined}
-
+
{wrap ? "Unwrap" : "Wrap"}
+
+
+
) : undefined}
-
+
) : undefined}
-
+
{wrap ? "Unwrap" : "Wrap"}
+
Review Comment:
Let's translate the tooltip content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2141347937
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -178,20 +200,57 @@ export const TaskLogHeader = ({
) : undefined}
-
+
{wrap ? "Unwrap" : "Wrap"}
+ {toggleExpanded ? (
+
+
+{expanded ? "Collapse All" : "Expand "}
+
+
+ ) : undefined}
{!isFullscreen && (
-
+
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
bbovenzi commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2127090289
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -178,20 +200,57 @@ export const TaskLogHeader = ({
) : undefined}
-
+
{wrap ? "Unwrap" : "Wrap"}
+ {toggleExpanded ? (
+
+
+{expanded ? "Collapse All" : "Expand "}
Review Comment:
I think its also ok to reuse the expand all / collapse all icons we use for
the grid view in `ToggleGroups.tsx`
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -111,6 +115,24 @@ export const TaskLogHeader = ({
[searchParams, setSearchParams],
);
+ useEffect(() => {
+if (!toggleExpanded) {
+ return undefined;
+}
+const handler = (event: KeyboardEvent) => {
+ if (event.key === "e" || event.key === "E") {
+event.preventDefault();
+toggleExpanded();
+ }
+};
+
+globalThis.addEventListener("keydown", handler);
+
+return () => {
+ globalThis.removeEventListener("keydown", handler);
+};
+ }, [toggleExpanded]);
+
Review Comment:
You can just check how we call `useHotkeys()` in other places
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -178,20 +200,57 @@ export const TaskLogHeader = ({
) : undefined}
-
+
{wrap ? "Unwrap" : "Wrap"}
+ {toggleExpanded ? (
+
+
+{expanded ? "Collapse All" : "Expand "}
+
+
+ ) : undefined}
{!isFullscreen && (
-
+
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2118070825
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/5aad151e-3404-4717-8150-deaea9c71259)
Additionally, the button's background color has been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-2925358490 I’d like to apologize for the incorrect merge I made earlier. I realize it may have caused confusion or disrupted the workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
bbovenzi commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-2920044285 Closes #47619 Looks like we have a merge conflict too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
bbovenzi commented on PR #51146: URL: https://github.com/apache/airflow/pull/51146#issuecomment-2920047167 Functionality-wise. I am wondering if a "Expand/Collapse All" would be better than flattening the logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
jscheffl commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2114324562
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/dc3fbd3d-e10e-4a6c-877f-cbc7b96ec447)
Can I kindly ask to normalize this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
jscheffl commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2114324562
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/dc3fbd3d-e10e-4a6c-877f-cbc7b96ec447)
Can I kindly ask to normalize this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2114301370
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/cd54a45a-4001-4cb5-b853-9869c3cd35d6)
I think i got it rigth this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
jscheffl commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2114118280
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/3dbf4c16-36c8-4b12-aba8-0b6737ed1992)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2113841844
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/cf91e03d-cd72-4a06-8f31-30eb144640be)
Distances ajusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
davidfgcorreia commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2113841844
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/cf91e03d-cd72-4a06-8f31-30eb144640be)
Disdances ajusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ui/logs)_#47619: add toggle for log grouping [airflow]
jscheffl commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2112672038
##
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##
@@ -189,6 +193,18 @@ export const TaskLogHeader = ({
{wrap ? "Unwrap" : "Wrap"}
+ {toggleNested ? (
+https://github.com/user-attachments/assets/698b48b0-be06-4851-8fcd-ae531f3bd075)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
