Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
mobuchowski merged PR #45182: URL: https://github.com/apache/airflow/pull/45182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
kacpermuda commented on code in PR #45182: URL: https://github.com/apache/airflow/pull/45182#discussion_r1923643948 ## providers/tests/common/compat/openlineage/utils/test_sql.py: ## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + + +def test_import(): Review Comment: I've only added it so that there is a corresponding test file for a compat module that I introduced recently. Other tests in compat provider look similar, but maybe we should remove them all if they are not really testing anything ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
mobuchowski commented on code in PR #45182: URL: https://github.com/apache/airflow/pull/45182#discussion_r1923633893 ## providers/tests/common/compat/openlineage/utils/test_sql.py: ## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + + +def test_import(): Review Comment: Why do we need that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
kacpermuda commented on PR #45182: URL: https://github.com/apache/airflow/pull/45182#issuecomment-2604186792 Thanks for the information. I've run some more manual tests, I think I even managed to run a system test with proxy (that was my main concern, if the proxy still works fine). I think it can be merged now, and once the dashboard is live again I'll check again if all works well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
fdemiane commented on PR #45182: URL: https://github.com/apache/airflow/pull/45182#issuecomment-2592636496 Hello @kacpermuda, Indeed the Google Providers Dashboard is down for maintenance. The example_cloud_sql_query.py system test was also failing on main since a long time, and I wasn't able to run it either. This needs investigation and most probably changes to the system test code. In the light of the above, I can recommend sticking to manually testing the operator, or maybe try to manually replicate in some way what the system test is doing for greater coverage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
kacpermuda commented on PR #45182: URL: https://github.com/apache/airflow/pull/45182#issuecomment-2578364800 Yeah, we can do that. I've tested it manually but if we can run the system tests as well it would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
mobuchowski commented on PR #45182: URL: https://github.com/apache/airflow/pull/45182#issuecomment-2578169009 @kacpermuda should we draft this PR until you verify if it works? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
michalmodras commented on PR #45182: URL: https://github.com/apache/airflow/pull/45182#issuecomment-2577326536 @fdemiane is currently working on some fixes in the Google system tests dashboard; @fdemiane can you please help @kacpermuda ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Add OpenLineage support for CloudSQLExecuteQueryOperator [airflow]
kacpermuda commented on PR #45182: URL: https://github.com/apache/airflow/pull/45182#issuecomment-2573146636 @ahidalgob @michalmodras As an addition to my manual tests I've done I wanted to run system tests for CloudSQLExecuteQueryOperator, but they seem to fail even on current main (breeze testing system-tests providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query.py). Also, the [system test dashboard](https://storage.googleapis.com/providers-dashboard-html/dashboard.html) provided by Google is not available, so I can't verify if those system tests fails only for me. Would appreciate any help in running those tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
