Re: [PR] feat: add partition_key to DagRunAssetReference [airflow]
jason810496 merged PR #61725: URL: https://github.com/apache/airflow/pull/61725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add partition_key to DagRunAssetReference [airflow]
jason810496 commented on PR #61725: URL: https://github.com/apache/airflow/pull/61725#issuecomment-3890270805 > Hey @jason810496 , i tried to add it. could you please take another look? Thanks! Sure! I will take a look after dinner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add partition_key to DagRunAssetReference [airflow]
Lee-W commented on PR #61725: URL: https://github.com/apache/airflow/pull/61725#issuecomment-3890234276 Hey @jason810496 , i tried to add it. could you please take another look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add partition_key to DagRunAssetReference [airflow]
Lee-W commented on PR #61725: URL: https://github.com/apache/airflow/pull/61725#issuecomment-3888181401 yep, will add it today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add partition_key to DagRunAssetReference [airflow]
pierrejeambrun commented on code in PR #61725: URL: https://github.com/apache/airflow/pull/61725#discussion_r2793491094 ## airflow-core/src/airflow/api_fastapi/execution_api/datamodels/asset_event.py: ## @@ -36,6 +36,7 @@ class DagRunAssetReference(StrictBaseModel): state: str data_interval_start: datetime | None data_interval_end: datetime | None +partition_key: str | None Review Comment: Yes we probably need a cadwyn migration to make sure task sdk is backward compatible in all 4 ways scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add partition_key to DagRunAssetReference [airflow]
jason810496 commented on code in PR #61725: URL: https://github.com/apache/airflow/pull/61725#discussion_r2789050333 ## airflow-core/src/airflow/api_fastapi/execution_api/datamodels/asset_event.py: ## @@ -36,6 +36,7 @@ class DagRunAssetReference(StrictBaseModel): state: str data_interval_start: datetime | None data_interval_end: datetime | None +partition_key: str | None Review Comment: Do we need to add migration file for `DagRunAssetReference` as well? https://github.com/apache/airflow/pull/61301/changes#diff-0a23579a81fc04c7f9c8ba7a8dab85a9957bca1c66976931e47ad17abbb75ba8R35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add partition_key to DagRunAssetReference [airflow]
jason810496 commented on code in PR #61725: URL: https://github.com/apache/airflow/pull/61725#discussion_r2789050333 ## airflow-core/src/airflow/api_fastapi/execution_api/datamodels/asset_event.py: ## @@ -36,6 +36,7 @@ class DagRunAssetReference(StrictBaseModel): state: str data_interval_start: datetime | None data_interval_end: datetime | None +partition_key: str | None Review Comment: Do we need to add migration file here as well? https://github.com/apache/airflow/pull/61301/changes#diff-0a23579a81fc04c7f9c8ba7a8dab85a9957bca1c66976931e47ad17abbb75ba8R35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
