Re: [PR] feat (airflowctl): add dag operations to conform all API endpoints [airflow]

2025-05-17 Thread via GitHub


bugraoz93 commented on PR #50424:
URL: https://github.com/apache/airflow/pull/50424#issuecomment-2888560963

   > > Looks good! Thanks @jx2lee!
   > 
   > Thanks for review @bugraoz93 ๐Ÿ™ Is there any ongoing issue related to 
remote CLI? It's such an interesting topicโ€”Iโ€™d love to keep contributing.
   
   I saw you have already found one. Thanks! :) 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat (airflowctl): add dag operations to conform all API endpoints [airflow]

2025-05-17 Thread via GitHub


bugraoz93 merged PR #50424:
URL: https://github.com/apache/airflow/pull/50424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat (airflowctl): add dag operations to conform all API endpoints [airflow]

2025-05-17 Thread via GitHub


bugraoz93 commented on PR #50424:
URL: https://github.com/apache/airflow/pull/50424#issuecomment-2888561448

   Rebasing and merging :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat (airflowctl): add dag operations to conform all API endpoints [airflow]

2025-05-16 Thread via GitHub


jx2lee commented on PR #50424:
URL: https://github.com/apache/airflow/pull/50424#issuecomment-2887909402

   > Looks good! Thanks @jx2lee!
   
   Thanks for review @bugraoz93 ๐Ÿ™


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat (airflowctl): add dag operations to conform all API endpoints [airflow]

2025-05-10 Thread via GitHub


bugraoz93 commented on PR #50424:
URL: https://github.com/apache/airflow/pull/50424#issuecomment-2868829860

   > @bugraoz93 
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_dag_runs
   > 
   > Does it need adding all query parameters to operation method? Existed 
method like [Get Dag 
Runs](https://github.com/apache/airflow/blob/09c3228ac0b119e107bfcca1e3561273cdf660ad/airflow-ctl/src/airflowctl/api/operations.py#L405),
 doesn't have all parameters.
   
   Yes, it would be ideal to include those parameters as well, but we can 
exclude DagRun from the scope of this one. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat (airflowctl): add dag operations to conform all API endpoints [airflow]

2025-05-10 Thread via GitHub


jx2lee commented on PR #50424:
URL: https://github.com/apache/airflow/pull/50424#issuecomment-2868668576

   @bugraoz93 
   
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_dag_runs
   
   Does it need adding all query parameters to operation method? Existed method 
like [Get Dag 
Runs](https://github.com/apache/airflow/blob/09c3228ac0b119e107bfcca1e3561273cdf660ad/airflow-ctl/src/airflowctl/api/operations.py#L405),
 doesn't have all parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org