Re: [PR] fix(asset): relax _validate_identifier isascii check [airflow]
Lee-W closed pull request #51604: fix(asset): relax _validate_identifier isascii check URL: https://github.com/apache/airflow/pull/51604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(asset): relax _validate_identifier isascii check [airflow]
uranusjr commented on PR #51604: URL: https://github.com/apache/airflow/pull/51604#issuecomment-2961922482 I don’t think a migration is necessary as long as we prevent non-ascii inputs. The current encoding is compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(asset): relax _validate_identifier isascii check [airflow]
Lee-W commented on PR #51604: URL: https://github.com/apache/airflow/pull/51604#issuecomment-2961350122 > We use latin1_general_cs to store the name (and group, asset values etc) on MySQL. This likely would not work for the entire Unicode space. > > Actually, `group` is also limited in the same way, and we are not correctly checking it now. Maybe we should limit the character set only when the metadatabase in MySQL. Sounds good. I guess we'll need a DB migration on the MySQL side then? probably worth changing it to 3.1.0 instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(asset): relax _validate_identifier isascii check [airflow]
uranusjr commented on PR #51604: URL: https://github.com/apache/airflow/pull/51604#issuecomment-2961191341 We use latin1_general_cs to store the name (and group, asset values etc) on MySQL. This likely would not work for the entire Unicode space. Actually, `group` is also limited in the same way, and we are not correctly checking it now. Maybe we should limit the character set only when the metadatabase in MySQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
