Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
github-actions[bot] commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4474514025 ### Backport failed to create: v3-2-test. View the failure log Run details Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x) the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches. In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel. Status Branch Result ❌ v3-2-test https://github.com/apache/airflow/commit/ac39596bd531f8df6092531b3bde7acb54fff16f";> You can attempt to backport this manually by running: ```bash cherry_picker ac39596 v3-2-test ``` This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
boring-cyborg[bot] commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4474509351 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
vatsrahul1001 merged PR #66431: URL: https://github.com/apache/airflow/pull/66431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
jscheffl commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4454953287 @ashb as I assume even if it is hard still OK to merge? I assume this also fixed one erro we had in production after applying the hotfix locally. So I think this is good. At least as a fix. General improvements welcome but would prevent waiting longer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
Pedrinhonitz commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4392715853 I agree that this whole process is difficult to understand. This PR focuses on the false mismatch of issue #66374, which occurs when IT is already scheduled with next_method after the trigger. A more comprehensive approach, such as "ignoring all executor SUCCESSES," would require a check to ensure that each consumer of these events is not unexpectedly affected. I am not entirely familiar with this control and have minimal knowledge about it; this was my first contribution, but your comment about the scheduler not needing to process SUCCESS makes sense to me, as that is the expected behavior. I apologize for my English. (I'm translating some points that I didn't understand, and I may have misinterpreted something.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
eladkal commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4388234544 Probably needs @ashb eyes to confirm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
henry3260 commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4386646877 Thanks for your fix! I'm just curious, is it possible that the scheduler picks up the TI very quickly and sets its state to `QUEUED`? In this case, it seems the scheduler would still mark the TI as `FAILED `when it receives the stale `SUCCESS `event. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
Pedrinhonitz commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4383644880 Perfect! I'm also eagerly awaiting another review and am open to other suggestions for resolving this issue. Thank you for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
jscheffl commented on code in PR #66431: URL: https://github.com/apache/airflow/pull/66431#discussion_r3190386970 ## airflow-core/newsfragments/66374.bugfix.rst: ## Review Comment: We should nto add a newsfragment for bug fixes. Not sure why we see more and more often newsfragments being added... this is NOT changelog. Please revert/remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(scheduler): ignore stale executor success after defer reschedule [airflow]
boring-cyborg[bot] commented on PR #66431: URL: https://github.com/apache/airflow/pull/66431#issuecomment-4381493693 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
