Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
choo121600 commented on PR #67234: URL: https://github.com/apache/airflow/pull/67234#issuecomment-4517078760 It looks like some parts are not yet present in 3-2-test. I think it would make sense to include this in a future release instead :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
github-actions[bot] commented on PR #67234: URL: https://github.com/apache/airflow/pull/67234#issuecomment-4517058158 ### Backport failed to create: v3-2-test. View the failure log Run details Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x) the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches. In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel. Status Branch Result ❌ v3-2-test https://github.com/apache/airflow/commit/93eee4fb31d49b1599a7766d7a91baf363712546";> You can attempt to backport this manually by running: ```bash cherry_picker 93eee4f v3-2-test ``` This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
github-actions[bot] commented on PR #67234: URL: https://github.com/apache/airflow/pull/67234#issuecomment-4517056226 Hi maintainer, this PR was merged without a milestone set. We've automatically set the milestone to **[Airflow 3.2.3](https://github.com/apache/airflow/milestone/140)** based on: backport label targeting v3-2-test If this milestone is not correct, please update it to the appropriate milestone. > This comment was generated by [Milestone Tag Assistant](https://github.com/apache/airflow/blob/main/.github/workflows/milestone-tag-assistant.yml). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
choo121600 merged PR #67234: URL: https://github.com/apache/airflow/pull/67234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
kddhhh23 commented on code in PR #67234: URL: https://github.com/apache/airflow/pull/67234#discussion_r3285738943 ## airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json: ## @@ -29,7 +29,7 @@ "group": "그룹", "lastAssetEvent": "마지막 에셋 이벤트", "name": "이름", - "producingTasks": "생성하는 태스크", + "producingTasks": "에셋 생성 태스크", Review Comment: Will revert this as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
kddhhh23 commented on code in PR #67234:
URL: https://github.com/apache/airflow/pull/67234#discussion_r3285737876
##
airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json:
##
@@ -2,8 +2,8 @@
"additional_data": "추가 데이터",
"asset_many": "에셋들",
"asset_one": "에셋",
- "consumingDags": "사용 중인 Dags",
- "consumingTasks": "사용 중인 Tasks",
+ "consumingDags": "에셋 사용 Dags",
+ "consumingTasks": "에셋 사용 태스크",
"createEvent": {
Review Comment:
Same as explained above — I initially added “asset” for clarity, but I’ll
revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
kddhhh23 commented on code in PR #67234: URL: https://github.com/apache/airflow/pull/67234#discussion_r3285729585 ## airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json: ## @@ -29,9 +29,9 @@ "group": "그룹", "lastAssetEvent": "마지막 에셋 이벤트", "name": "이름", - "producingTasks": "생성하는 태스크", + "producingTasks": "생성하는 작업", Review Comment: Thanks for the feedback. As mentioned in the PR description, I initially included “에셋” to make the relationship explicit. However, I agree that since this is already within the Asset page context, it may be redundant. I’ll update the terms back to “사용 중인” and “생성 중인” and will keep conciseness in mind for future translations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
choo121600 commented on code in PR #67234: URL: https://github.com/apache/airflow/pull/67234#discussion_r3285693844 ## airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json: ## @@ -29,9 +29,9 @@ "group": "그룹", "lastAssetEvent": "마지막 에셋 이벤트", "name": "이름", - "producingTasks": "생성하는 태스크", + "producingTasks": "생성하는 작업", Review Comment: I think “사용 중인 Dags” and “사용 중인 태스크” may read more naturally than “에셋 사용 DAGs”. Since these labels already appear within the Asset page context, users can still understand them as “Dags/tasks using this asset” even without explicitly repeating “에셋”. So in this case, I feel the shorter phrasing may be clearer and less repetitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
choo121600 commented on code in PR #67234:
URL: https://github.com/apache/airflow/pull/67234#discussion_r3285671156
##
airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json:
##
@@ -29,7 +29,7 @@
"group": "그룹",
"lastAssetEvent": "마지막 에셋 이벤트",
"name": "이름",
- "producingTasks": "생성하는 태스크",
+ "producingTasks": "에셋 생성 태스크",
Review Comment:
this too
##
airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json:
##
@@ -2,8 +2,8 @@
"additional_data": "추가 데이터",
"asset_many": "에셋들",
"asset_one": "에셋",
- "consumingDags": "사용 중인 Dags",
- "consumingTasks": "사용 중인 Tasks",
+ "consumingDags": "에셋 사용 Dags",
+ "consumingTasks": "에셋 사용 태스크",
"createEvent": {
Review Comment:
What was the reason for changing “사용 중인” to “에셋 사용”?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
kddhhh23 commented on PR #67234: URL: https://github.com/apache/airflow/pull/67234#issuecomment-4510834909 I have pushed a new commit and updated the PR description based on feedback. Please take a look when you have a moment. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
choo121600 commented on PR #67234: URL: https://github.com/apache/airflow/pull/67234#issuecomment-4500063563 Yes, I think that would make sense for consistency :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
kddhhh23 commented on code in PR #67234: URL: https://github.com/apache/airflow/pull/67234#discussion_r3275102624 ## airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json: ## @@ -29,9 +29,9 @@ "group": "그룹", "lastAssetEvent": "마지막 에셋 이벤트", "name": "이름", - "producingTasks": "생성하는 태스크", + "producingTasks": "생성하는 작업", Review Comment: Thank you for the review! I looked into this a bit more and found that in `airflow-core/src/airflow/models/asset.py`, `TaskOutletAssetReference`, which corresponds to `producingTasks`, is described as “References from a task to an asset that it updates / produces.” `TaskInletAssetReference`, which corresponds to `consumingTasks`, is described as “References from a task to an asset that it references as an inlet.” Based on that, these labels seem to describe the relationship between an asset and tasks rather than an in-progress state. So I think translating `producingTasks` as “에셋 생성 태스크” and `consumingTasks` as “에셋 사용 태스크” would be clearer. Please let me know what you think. (“The term ‘태스크’ was chosen based on the comment below.”) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
kddhhh23 commented on PR #67234: URL: https://github.com/apache/airflow/pull/67234#issuecomment-4499913836 Thank you for the suggestion! In that case, would it make sense to consistently replace existing translations of “작업” with “태스크” across all files under `airflow-core/src/airflow/ui/public/i18n/locales/ko/` as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
kddhhh23 commented on code in PR #67234: URL: https://github.com/apache/airflow/pull/67234#discussion_r3275102624 ## airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json: ## @@ -29,9 +29,9 @@ "group": "그룹", "lastAssetEvent": "마지막 에셋 이벤트", "name": "이름", - "producingTasks": "생성하는 태스크", + "producingTasks": "생성하는 작업", Review Comment: I looked into this a bit more and found that in `airflow-core/src/airflow/models/asset.py`, `TaskOutletAssetReference`, which corresponds to `producingTasks`, is described as “References from a task to an asset that it updates / produces.” `TaskInletAssetReference`, which corresponds to `consumingTasks`, is described as “References from a task to an asset that it references as an inlet.” Based on that, these labels seem to describe the relationship between an asset and tasks rather than an in-progress state. So I think translating `producingTasks` as “에셋 생성 태스크” and `consumingTasks` as “에셋 사용 태스크” would be clearer. Please let me know what you think. (“The term ‘태스크’ was chosen based on the comment below.”) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n(ko): Improve Korean Task terminology consistency [airflow]
noeunkim commented on code in PR #67234: URL: https://github.com/apache/airflow/pull/67234#discussion_r3273850908 ## airflow-core/src/airflow/ui/public/i18n/locales/ko/assets.json: ## @@ -29,9 +29,9 @@ "group": "그룹", "lastAssetEvent": "마지막 에셋 이벤트", "name": "이름", - "producingTasks": "생성하는 태스크", + "producingTasks": "생성하는 작업", Review Comment: How about standarize on `생성하는` over `생성 중인`? > e.g. currently `consumingTasks` is translated to `사용 중인 작업` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
