Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
bbovenzi merged PR #51558: URL: https://github.com/apache/airflow/pull/51558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
guan404ming commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2140334414
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/common.json:
##
@@ -49,13 +63,14 @@
"noItemsFound": "找不到{{modelName}}",
Review Comment:
```suggestion
"noItemsFound": "找不到 {{modelName}}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
Lee-W commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2139517689
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/assets.json:
##
@@ -0,0 +1,10 @@
+{
+ "columns": {
+"consumingDags": "消費 Dags",
Review Comment:
```suggestion
"consumingDags": "消費者 Dags",
```
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/admin.json:
##
@@ -0,0 +1,149 @@
+{
+ "columns":{
+"description": "描述",
+"key": "鍵",
+"name": "名稱",
+"value": "值"
+ },
+ "config":{
+"columns":{
+ "section": "區段"
+},
+"title": "Airflow 設定"
+ },
+ "connections":{
+"add":"新增連線",
+"columns":{
+ "connectionId": "連線 ID",
+ "connectionType": "連線類型",
+ "host": "主機",
+ "port": "埠"
+},
+"delete":{
+ "deleteConnection_one": "刪除1個連線",
+ "deleteConnection_other": "刪除 {{count}} 個連線",
+ "firstConfirmMessage_one": "您即將刪除以下連線：",
+ "firstConfirmMessage_other": "您即將刪除以下連線：",
+ "title": "刪除連線"
+},
+"edit": "編輯連線",
+"form":{
+ "connectionIdRequired": "連線 ID 是必填的",
+ "connectionIdRequirement": "連線 ID 不能只包含空格",
+ "connectionTypeRequired": "連線類型是必填的",
+ "extraFields": "額外欄位",
+ "extraFieldsJson": "額外欄位 JSON",
+ "helperText": "找不到連線類型？請確保您已安裝對應的 Airflow Providers 套件。",
+ "selectConnectionType": "選擇連線類型",
+ "standardFields": "標準欄位"
+},
+"noRowMessage": "找不到連線",
+"searchPlaceholder": "搜尋連線",
+"standardFields":{
+ "Description": "描述",
+ "Host": "主機",
+ "Login": "登入",
+ "Password": "密碼",
+ "Port": "埠",
+ "Schema": "資料庫結構(Schema)"
+},
+"test": "測試連線",
+"testDisabled": "測試連線功能已停用。請聯繫管理員以啟用。"
+ },
+ "deleteActions":{
+"button": "刪除",
+"modal":{
+ "confirmButton": "確定刪除",
+ "secondConfirmMessage": "此動作無法復原。",
+ "thirdConfirmMessage": "您確定要繼續嗎？"
+},
+"selected": "已選取"
+ },
+ "formActions":{
+"reset": "重置",
+"save": "儲存"
+ },
+ "plugins": {
+"columns": {
+ "source": "來源"
+},
+"importError_one": "外掛匯入錯誤",
+"importError_other": "外掛匯入錯誤",
+"searchPlaceholder": "搜尋檔案"
+ },
+ "pools": {
+"add": "新增資源池",
+"deferredSlotsIncluded": "包含延後任務",
+"delete":{
+ "title": "刪除資源池",
+ "warning": "這將刪除所有與此資源池相關的系統資料，可能會影響使用此資源池的任務。"
+},
+"edit": "編輯資源池",
+"form": {
+ "checkbox": "計算可用資源池配額時，將包含延後的任務",
+ "description": "描述",
+ "includeDeferred": "包含延後任務",
+ "nameMaxLength": "名稱最多只能包含 256 個字元",
+ "nameRequired": "名稱是必填的",
+ "slots": "配額"
+},
+"noPoolsFound": "找不到資源池",
+"searchPlaceholder": "搜尋資源池",
+"sort": {
+ "asc": "名稱 (A-Z)",
+ "desc": "名稱 (Z-A)",
+ "placeholder": "排序方式"
+}
+ },
+ "providers": {
+"columns": {
+ "packageName": "套件名稱",
+ "version": "版本"
+}
+ },
+ "variables": {
+"add": "新增變數",
+"columns": {
+ "isEncrypted": "是否加密"
+},
+"delete": {
+ "deleteVariable_one": "刪除1個變數",
Review Comment:
```suggestion
"deleteVariable_one": "刪除 1 個變數",
```
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/common.json:
##
@@ -25,6 +27,18 @@
"githubRepo": "GitHub 倉庫",
"restApiReference": "REST API 參考"
},
+ "duration": {
+"label": "持續時間",
+"seconds": "{{count}}秒"
Review Comment:
```suggestion
"seconds": "{{count}} 秒"
```
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/admin.json:
##
@@ -0,0 +1,149 @@
+{
+ "columns":{
+"description": "描述",
+"key": "鍵",
+"name": "名稱",
+"value": "值"
+ },
+ "config":{
+"columns":{
+ "section": "區段"
+},
+"title": "Airflow 設定"
+ },
+ "connections":{
+"add":"新增連線",
+"columns":{
+ "connectionId": "連線 ID",
+ "connectionType": "連線類型",
+ "host": "主機",
+ "port": "埠"
+},
+"delete":{
+ "deleteConnection_one": "刪除1個連線",
Review Comment:
```suggestion
"deleteConnection_one": "刪除 1 個連線",
```
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/admin.json:
##
@@ -0,0 +1,149 @@
+{
+ "columns":{
+"description": "描述",
+"key": "鍵",
+"name": "名稱",
+"value": "值"
+ },
+ "config":{
+"columns":{
+ "section": "區段"
+},
+"title": "Airflow 設定"
+ },
+ "connections":{
+"add":"新增連線",
+"columns":{
+ "connectionId": "連線 ID",
+ "connectionType": "連線類型",
+ "host": "主機",
+ "port": "埠"
+},
+"delete":{
+ "deleteConnection_one": "刪除1個連線",
+ "deleteConnection_other": "刪除 {{count}} 個連線",
+ "firstConfirmMessage_one": "您即將刪除以下連線：",
+ "firstConfirmMessage_other": "您即將刪除以下連線：",
+ "title": "刪除連線"
+},
+"edit": "編輯連線",
+"form":{
+ "connectionIdRequired": "連線 ID 是必填的",
+ "connectionIdRequirement": "連線 ID 不能只包含空格",
+ "connectionTypeRequired": "連線類型是必填的",
+ "ex
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
bbovenzi commented on PR #51558: URL: https://github.com/apache/airflow/pull/51558#issuecomment-2960481108 Overall it looks good to me. Let's just try to reuse translations already in `common.json`. I'll leave the zh-tw translations for others -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
bbovenzi commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2138698125
##
airflow-core/src/airflow/ui/src/i18n/locales/en/browse.json:
##
@@ -0,0 +1,29 @@
+{
+ "auditLog":{
+"actions": {
+ "collapseAllExtra": "Collapse all extra json",
+ "expandAllExtra": "Expand all extra json"
+},
+"columns":{
+ "event": "Event",
+ "extra": "Extra",
+ "tryNumber": "Try Number",
Review Comment:
We also have tryNumber in `common`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
bbovenzi commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2138697617
##
airflow-core/src/airflow/ui/src/i18n/locales/en/browse.json:
##
@@ -0,0 +1,29 @@
+{
+ "auditLog":{
+"actions": {
+ "collapseAllExtra": "Collapse all extra json",
+ "expandAllExtra": "Expand all extra json"
+},
+"columns":{
+ "event": "Event",
+ "extra": "Extra",
+ "tryNumber": "Try Number",
+ "user": "User",
+ "when": "When"
+},
+"title": "Audit Log Events"
+ },
+ "columns":{
+"dagId": "Dag ID",
+"mapIndex": "Map Index",
+"runId": "Run ID",
+"taskId": "Task ID"
Review Comment:
These all exist as common keys I believe. Let's just reuse those instead of
declaring them again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
RoyLee1224 commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2138268628
##
airflow-core/src/airflow/ui/src/i18n/locales/en/admin.json:
##
@@ -0,0 +1,146 @@
+{
+ "columns":{
+"description": "Description",
+"key": "Key",
+"name": "Name",
+"value": "Value"
+ },
+ "config":{
+"columns":{
+ "section": "Section"
+},
+"title": "Airflow Configuration"
+ },
+ "connections":{
+"add":"Add Connection",
+"columns":{
+ "connectionId": "Connection ID",
+ "connectionType": "Connection Type",
+ "host": "Host",
+ "port": "Port"
+},
+"delete":{
+ "deleteConnection_one": "Delete {{count}} connection",
+ "deleteConnection_other": "Delete {{count}} connections",
+ "firstConfirmMessage_one": "You are about to delete the following
connection:",
+ "firstConfirmMessage_other": "You are about to delete the following
connections:",
+ "secondConfirmMessage": "This action is permanent and cannot be undone.
Are you sure you want to proceed?",
Review Comment:
I noticed that hardcoding a space in the JSX (e.g., {" "}) between the two
sentences isn't ideal for internationalization, as some languages, like
Chinese, don't use a leading space.
To solve this, I've included the leading space within the
`thirdConfirmMessage` key in the English JSON file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
RoyLee1224 commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2138268628
##
airflow-core/src/airflow/ui/src/i18n/locales/en/admin.json:
##
@@ -0,0 +1,146 @@
+{
+ "columns":{
+"description": "Description",
+"key": "Key",
+"name": "Name",
+"value": "Value"
+ },
+ "config":{
+"columns":{
+ "section": "Section"
+},
+"title": "Airflow Configuration"
+ },
+ "connections":{
+"add":"Add Connection",
+"columns":{
+ "connectionId": "Connection ID",
+ "connectionType": "Connection Type",
+ "host": "Host",
+ "port": "Port"
+},
+"delete":{
+ "deleteConnection_one": "Delete {{count}} connection",
+ "deleteConnection_other": "Delete {{count}} connections",
+ "firstConfirmMessage_one": "You are about to delete the following
connection:",
+ "firstConfirmMessage_other": "You are about to delete the following
connections:",
+ "secondConfirmMessage": "This action is permanent and cannot be undone.
Are you sure you want to proceed?",
Review Comment:
I noticed that hardcoding a space in the JSX (e.g., {" "}) between the two
sentences isn't ideal for internationalization, as some languages, like
Chinese, don't use a leading space.
To solve this, I've included the leading space within the
`thirdConfirmMessage` key in the source English JSON file.
##
airflow-core/src/airflow/ui/src/i18n/locales/en/admin.json:
##
@@ -0,0 +1,146 @@
+{
+ "columns":{
+"description": "Description",
+"key": "Key",
+"name": "Name",
+"value": "Value"
+ },
+ "config":{
+"columns":{
+ "section": "Section"
+},
+"title": "Airflow Configuration"
+ },
+ "connections":{
+"add":"Add Connection",
+"columns":{
+ "connectionId": "Connection ID",
+ "connectionType": "Connection Type",
+ "host": "Host",
+ "port": "Port"
+},
+"delete":{
+ "deleteConnection_one": "Delete {{count}} connection",
+ "deleteConnection_other": "Delete {{count}} connections",
+ "firstConfirmMessage_one": "You are about to delete the following
connection:",
+ "firstConfirmMessage_other": "You are about to delete the following
connections:",
+ "secondConfirmMessage": "This action is permanent and cannot be undone.
Are you sure you want to proceed?",
Review Comment:
This is the approach I came up with, but I'm very open to other suggestions
if there's a more standard or preferred way to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
RoyLee1224 commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2138166466
##
airflow-core/src/airflow/ui/src/i18n/locales/en/admin.json:
##
@@ -0,0 +1,146 @@
+{
+ "columns":{
+"description": "Description",
+"key": "Key",
+"name": "Name",
+"value": "Value"
+ },
+ "config":{
+"columns":{
+ "section": "Section"
+},
+"title": "Airflow Configuration"
+ },
+ "connections":{
+"add":"Add Connection",
+"columns":{
+ "connectionId": "Connection ID",
+ "connectionType": "Connection Type",
+ "host": "Host",
+ "port": "Port"
+},
+"delete":{
+ "deleteConnection_one": "Delete {{count}} connection",
+ "deleteConnection_other": "Delete {{count}} connections",
+ "firstConfirmMessage_one": "You are about to delete the following
connection:",
+ "firstConfirmMessage_other": "You are about to delete the following
connections:",
+ "secondConfirmMessage": "This action is permanent and cannot be undone.
Are you sure you want to proceed?",
Review Comment:
Sure, I'll remove the usage of `Trans` Components and slightly modify the
wording in Delete Modal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
RoyLee1224 commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2138158470
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/admin.json:
##
@@ -0,0 +1,146 @@
+{
+ "columns":{
+"description": "描述",
+"key": "鍵",
+"name": "名稱",
+"value": "值"
+ },
+ "config":{
+"columns":{
+ "section": "區段"
+},
+"title": "Airflow 設定"
+ },
+ "connections":{
+"add":"新增連線",
+"columns":{
+ "connectionId": "連線 ID",
+ "connectionType": "連線類型",
+ "host": "主機",
+ "port": "埠"
+},
+"delete":{
+ "deleteConnection_one": "刪除 {{count}} 個連線",
Review Comment:
Oh you're right, let me fix it. Thanks for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
RoyLee1224 commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2138136058
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/assets.json:
##
@@ -0,0 +1,10 @@
+{
+ "columns": {
+"consumingDags": "消費Dag",
Review Comment:
Sure, makes perfect sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
Lee-W commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2137612348
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/admin.json:
##
@@ -0,0 +1,146 @@
+{
+ "columns":{
+"description": "描述",
+"key": "鍵",
+"name": "名稱",
+"value": "值"
+ },
+ "config":{
+"columns":{
+ "section": "區段"
+},
+"title": "Airflow 設定"
+ },
+ "connections":{
+"add":"新增連線",
+"columns":{
+ "connectionId": "連線 ID",
+ "connectionType": "連線類型",
+ "host": "主機",
+ "port": "埠"
+},
+"delete":{
+ "deleteConnection_one": "刪除 {{count}} 個連線",
Review Comment:
I thought it would always be one. Do we need to pass variable here?
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/assets.json:
##
@@ -0,0 +1,10 @@
+{
+ "columns": {
+"consumingDags": "消費Dag",
+"group": "群組",
+"lastAssetEvent": "上次資源事件",
Review Comment:
```suggestion
"lastAssetEvent": "最後資源事件",
```
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/common.json:
##
@@ -49,13 +63,14 @@
"noItemsFound": "找不到{{modelName}}",
"pools": {
"deferred": "已延後",
-"open": "開啟",
+"open": "開放",
"pools_one": "資源池",
"pools_other": "資源池",
"queued": "排隊中",
"running": "執行中",
"scheduled": "已排程"
},
+ "runId": "執行ID",
Review Comment:
```suggestion
"runId": "執行 ID",
```
##
airflow-core/src/airflow/ui/src/i18n/locales/zh-TW/assets.json:
##
@@ -0,0 +1,10 @@
+{
+ "columns": {
+"consumingDags": "消費Dag",
Review Comment:
```suggestion
"consumingDags": "消費者 Dag",
```
Basically, `consumingDags` are the dags that consume this asset event, and
the downstream ones are consumers. I think it might be better to understand a
bit 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
RoyLee1224 commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2137526996
##
airflow-core/src/airflow/ui/src/pages/Connections/ConnectionForm.tsx:
##
@@ -20,10 +20,11 @@ import { Input, Button, Box, Spacer, HStack, Field, Stack,
VStack, Spinner } fro
import { Select } from "chakra-react-select";
import { useEffect, useState } from "react";
import { useForm, Controller } from "react-hook-form";
+import { useTranslation } from "react-i18next";
import { FiSave } from "react-icons/fi";
import { ErrorAlert } from "src/components/ErrorAlert";
-import { FlexibleForm, flexibleFormExtraFieldSection } from
"src/components/FlexibleForm";
Review Comment:
Sure, that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
RoyLee1224 commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2137540195
##
airflow-core/src/airflow/ui/src/pages/Connections/ConnectionStandardFields.tsx:
##
@@ -49,6 +51,7 @@ const StandardFields = ({ control, standardFields }:
StandardFieldsProps) => {
+{/*
{translate(`connections.standardFields.${fields.title}`)} */}
Review Comment:
Oh, I commented that out while investigating how to handle the dynamic
fields mentioned in my discussion question above. I'll remove these
commented-out code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
jscheffl commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2136566471
##
airflow-core/src/airflow/ui/src/pages/Connections/ConnectionForm.tsx:
##
@@ -20,10 +20,11 @@ import { Input, Button, Box, Spacer, HStack, Field, Stack,
VStack, Spinner } fro
import { Select } from "chakra-react-select";
import { useEffect, useState } from "react";
import { useForm, Controller } from "react-hook-form";
+import { useTranslation } from "react-i18next";
import { FiSave } from "react-icons/fi";
import { ErrorAlert } from "src/components/ErrorAlert";
-import { FlexibleForm, flexibleFormExtraFieldSection } from
"src/components/FlexibleForm";
Review Comment:
If you remove the (here: the only) use of the constants, can you remove them
from airflow-core/src/airflow/ui/src/components/FlexibleForm/index.tsx as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
jscheffl commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2136567582
##
airflow-core/src/airflow/ui/src/pages/Connections/ConnectionStandardFields.tsx:
##
@@ -49,6 +51,7 @@ const StandardFields = ({ control, standardFields }:
StandardFieldsProps) => {
+{/*
{translate(`connections.standardFields.${fields.title}`)} */}
Review Comment:
Why is this commented-out? Is the still DRAFT code? Can you please make this
clean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
jscheffl commented on code in PR #51558:
URL: https://github.com/apache/airflow/pull/51558#discussion_r2136569183
##
airflow-core/src/airflow/ui/src/i18n/locales/en/admin.json:
##
@@ -0,0 +1,146 @@
+{
+ "columns":{
+"description": "Description",
+"key": "Key",
+"name": "Name",
+"value": "Value"
+ },
+ "config":{
+"columns":{
+ "section": "Section"
+},
+"title": "Airflow Configuration"
+ },
+ "connections":{
+"add":"Add Connection",
+"columns":{
+ "connectionId": "Connection ID",
+ "connectionType": "Connection Type",
+ "host": "Host",
+ "port": "Port"
+},
+"delete":{
+ "deleteConnection_one": "Delete {{count}} connection",
+ "deleteConnection_other": "Delete {{count}} connections",
+ "firstConfirmMessage_one": "You are about to delete the following
connection:",
+ "firstConfirmMessage_other": "You are about to delete the following
connections:",
+ "secondConfirmMessage": "This action is permanent and cannot be undone.
Are you sure you want to proceed?",
Review Comment:
Can you separate this snipped into two lines, not having HTML code in the
translation please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
jscheffl commented on PR #51558: URL: https://github.com/apache/airflow/pull/51558#issuecomment-2957113586 Note: Static check will be fixed with https://github.com/apache/airflow/pull/51557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] i18n: Add translations for Assets, Browse, and Admin pages [airflow]
jscheffl commented on PR #51558: URL: https://github.com/apache/airflow/pull/51558#issuecomment-2957111672 Ah, cool you are literally doing exactly the same I attempted, but you are far advanced. I also consolidated the "connections.json" into an admin.json. Cool! So actually wanted to raise a PR in 3 minutes and just saw yours. Will drop mine. But your's is large and I need to get to bed... if nobody else takes a look I'll check in ~24h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
