Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
potiuk merged PR #48781: URL: https://github.com/apache/airflow/pull/48781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
potiuk commented on code in PR #48781: URL: https://github.com/apache/airflow/pull/48781#discussion_r2220231690 ## dev/breeze/src/airflow_breeze/commands/ci_image_commands.py: ## @@ -188,7 +188,7 @@ def prepare_for_building_ci_image(params: BuildCiParams): make_sure_builder_configured(params=params) -def build_timout_handler(build_process_group_id: int, signum, frame): +def build_timeout_handler(build_process_group_id: int, signum, frame): Review Comment: Ah ... Already removed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
potiuk commented on code in PR #48781: URL: https://github.com/apache/airflow/pull/48781#discussion_r2220221555 ## dev/breeze/src/airflow_breeze/commands/ci_image_commands.py: ## @@ -188,7 +188,7 @@ def prepare_for_building_ci_image(params: BuildCiParams): make_sure_builder_configured(params=params) -def build_timout_handler(build_process_group_id: int, signum, frame): +def build_timeout_handler(build_process_group_id: int, signum, frame): Review Comment: Maybe- but I prefer to separate such removal from pure spelling changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
uranusjr commented on code in PR #48781: URL: https://github.com/apache/airflow/pull/48781#discussion_r2142085813 ## dev/breeze/src/airflow_breeze/utils/run_utils.py: ## @@ -81,7 +81,7 @@ def run_command( :param cmd: command to run :param title: optional title for the command (otherwise likely title is automatically determined) -:param check: whether to check status value and run exception (same as POpem) +:param check: whether to check status value and run exception (same as POpen) Review Comment: ```suggestion :param check: whether to check status value and run exception (same as Popen) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
uranusjr commented on code in PR #48781: URL: https://github.com/apache/airflow/pull/48781#discussion_r2142085001 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -2964,7 +2964,7 @@ def modify_single_file_constraints( def modify_all_constraint_files( constraints_repo: Path, updated_constraint: tuple[str, ...] | None, -comit_file: Path | None, +commit_file: Path | None, Review Comment: Actually this is still wrong. Judged from the call site, it should be *comment* instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
uranusjr commented on code in PR #48781: URL: https://github.com/apache/airflow/pull/48781#discussion_r2142083132 ## dev/breeze/src/airflow_breeze/commands/ci_image_commands.py: ## @@ -188,7 +188,7 @@ def prepare_for_building_ci_image(params: BuildCiParams): make_sure_builder_configured(params=params) -def build_timout_handler(build_process_group_id: int, signum, frame): +def build_timeout_handler(build_process_group_id: int, signum, frame): Review Comment: Looks like this function isn’t actually used anywhere? Maybe we can just remove it? cc @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
github-actions[bot] commented on PR #48781: URL: https://github.com/apache/airflow/pull/48781#issuecomment-2954355102 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
jbampton commented on PR #48781: URL: https://github.com/apache/airflow/pull/48781#issuecomment-2787015791 I created an issue in CloudStack https://github.com/apache/cloudstack/issues/10639 Basically outlines how I'm using codespell with a shell script to create totals of misspelled words. Also I have found that the Rust crate `typos` seems to be more advanced than the Python package `codespell`: https://crates.io/crates/typos You can basically use `typos` the same way for example: ` typos docs/ | cut -f2 -d' ' | tr A-Z a-z | sort | uniq -c | sort -nr > typos.txt` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] misc: fix spelling in md,py,rst,yaml files [airflow]
rawwar commented on PR #48781: URL: https://github.com/apache/airflow/pull/48781#issuecomment-2777602523 Are you using any tool to find these spelling mistakes? I've seen you making such changes in multiple Apache projects. So, just curious to know if it is an automated check or if you are going through the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
