Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
rawwar merged PR #51026: URL: https://github.com/apache/airflow/pull/51026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
ashb commented on code in PR #51026: URL: https://github.com/apache/airflow/pull/51026#discussion_r2142076016 ## airflow-core/src/airflow/migrations/versions/0070_3_1_0_rename_and_change_type_of_deadline_column.py: ## @@ -17,7 +17,7 @@ # under the License. """ -Change the Deadline column in the Deadline table from DateTime to UTC DateTime. Review Comment: Yeah, that's correct. (It will mean anyone trying to have a persistent DB following main will need to db reset or manually fix things, but that is to be expected if you follow main) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
rawwar commented on code in PR #51026: URL: https://github.com/apache/airflow/pull/51026#discussion_r2141810549 ## airflow-core/src/airflow/migrations/versions/0070_3_1_0_rename_and_change_type_of_deadline_column.py: ## @@ -17,7 +17,7 @@ # under the License. """ -Change the Deadline column in the Deadline table from DateTime to UTC DateTime. Review Comment: I think, that's true for any released version. But, since, this is for 3.1.0, we can do this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] rename deadline column to "deadline_at" in Deadline Table [airflow]
ferruzzi commented on code in PR #51026: URL: https://github.com/apache/airflow/pull/51026#discussion_r2138600162 ## airflow-core/src/airflow/migrations/versions/0070_3_1_0_rename_and_change_type_of_deadline_column.py: ## @@ -17,7 +17,7 @@ # under the License. """ -Change the Deadline column in the Deadline table from DateTime to UTC DateTime. Review Comment: Wait, can we modify migrations? I could certainly be wrong, but I thought these were pretty immutable once they get merged and changing them would break stuff? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
