Re: [PR] CAMEL-23385: Fix watch mode exit and terminal resource leak [camel]
davsclaus merged PR #23130: URL: https://github.com/apache/camel/pull/23130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-23385: Fix watch mode exit and terminal resource leak [camel]
github-actions[bot] commented on PR #23130: URL: https://github.com/apache/camel/pull/23130#issuecomment-4427803564 :test_tube: **CI tested the following changed modules:** - `dsl/camel-jbang/camel-jbang-core` :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification: - `dsl/camel-jbang/camel-jbang-core`: 1 test(s) disabled on GitHub Actions :bulb: **Manual integration tests recommended:** > You modified `dsl/camel-jbang/camel-jbang-core`. The related integration tests in `dsl/camel-jbang/camel-jbang-it` are excluded from CI. Consider running them manually: > ``` > mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test > ``` All tested modules (6 modules) - Camel :: JBang :: Core - Camel :: JBang :: MCP - Camel :: JBang :: Plugin :: Route Parser - Camel :: JBang :: Plugin :: TUI - Camel :: JBang :: Plugin :: Validate - Camel :: Launcher :: Container --- :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25716083061) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-23385: Fix watch mode exit and terminal resource leak [camel]
github-actions[bot] commented on PR #23130: URL: https://github.com/apache/camel/pull/23130#issuecomment-4427707133 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI. * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] CAMEL-23385: Fix watch mode exit and terminal resource leak [camel]
gnodet opened a new pull request, #23130: URL: https://github.com/apache/camel/pull/23130 [CAMEL-23385](https://issues.apache.org/jira/browse/CAMEL-23385) Follow-up to #23121 — fixes three bugs introduced in the watch mode implementation: 1. **Shadowed `running` variable prevents watch exit**: `ActionWatchCommand.doCall()` declared a local `AtomicBoolean running` that shadowed the field. The `waitForUserEnter()` method set the *field* to false, but the loop checked the *local* — so pressing Enter could never exit the watch loop. 2. **`CamelRouteDiagramAction.waitForUserEnter()` never signals stop**: The override read a line from `lineReader` but never called `running.set(false)`, so even without the shadowing bug, the loop would continue after the user pressed Enter. 3. **Terminal resource leak**: The terminal opened in `doCall()` was stored as a field but never closed. Wrapped in try/finally to ensure cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
