Re: [PR] Move from deprecated StrimziKafkaContainer to StrimziKafkaCluster [camel-quarkus]
jamesnetherton commented on PR #8226: URL: https://github.com/apache/camel-quarkus/pull/8226#issuecomment-4222070642 This upgrade has been completed on the `quarkus-main` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move from deprecated StrimziKafkaContainer to StrimziKafkaCluster [camel-quarkus]
jamesnetherton closed pull request #8226: Move from deprecated StrimziKafkaContainer to StrimziKafkaCluster URL: https://github.com/apache/camel-quarkus/pull/8226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move from deprecated StrimziKafkaContainer to StrimziKafkaCluster [camel-quarkus]
apupier commented on PR #8226: URL: https://github.com/apache/camel-quarkus/pull/8226#issuecomment-3822664012 some more changes required: ``` [0](https://github.com/apache/camel-quarkus/actions/runs/21508743587/job/61970448298?pr=8226#step:8:78261) Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure /home/runner/work/camel-quarkus/camel-quarkus/integration-tests/kafka-sasl-ssl/src/test/java/org/apache/camel/quarkus/kafka/sasl/KafkaSaslSslTestResource.java:[49,49] incompatible types: bad return type in lambda expression org.apache.camel.quarkus.kafka.sasl.KafkaSaslSslTestResource.SaslSslKafkaContainer cannot be converted to io.strimzi.test.container.StrimziKafkaCluster ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Move from deprecated StrimziKafkaContainer to StrimziKafkaCluster [camel-quarkus]
apupier commented on code in PR #8226:
URL: https://github.com/apache/camel-quarkus/pull/8226#discussion_r2745099351
##
integration-tests-support/kafka/src/main/java/org/apache/camel/quarkus/test/support/kafka/KafkaTestResource.java:
##
@@ -16,33 +16,39 @@
*/
package org.apache.camel.quarkus.test.support.kafka;
+import java.util.Collection;
import java.util.Collections;
import java.util.Map;
import java.util.function.Function;
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
-import io.strimzi.test.container.StrimziKafkaContainer;
+import io.strimzi.test.container.StrimziKafkaCluster;
import org.eclipse.microprofile.config.ConfigProvider;
+import org.testcontainers.containers.GenericContainer;
public class KafkaTestResource implements QuarkusTestResourceLifecycleManager {
protected static final String KAFKA_IMAGE_NAME =
ConfigProvider.getConfig().getValue("kafka.container.image", String.class);
-private StrimziKafkaContainer container;
+private StrimziKafkaCluster container;
@Override
public Map start() {
try {
-start(name -> new StrimziKafkaContainer(name));
+start(name -> new StrimziKafkaCluster.StrimziKafkaClusterBuilder()
+.withNumberOfBrokers(1)
+.build());
return Collections.singletonMap("camel.component.kafka.brokers",
container.getBootstrapServers());
} catch (Exception e) {
throw new RuntimeException(e);
}
}
-public String start(Function
containerSupplier) {
+public String start(Function
containerSupplier) {
container = containerSupplier.apply(KAFKA_IMAGE_NAME);
-container.withLogConsumer(frame ->
System.out.print(frame.getUtf8String()))
-.waitForRunning()
-.start();
+Collection> nodes = container.getNodes();
+for (GenericContainer genericContainer : nodes) {
+genericContainer.withLogConsumer(frame ->
System.out.print(frame.getUtf8String()));
+}
+container.start();
Review Comment:
I'm not completed sure that it is bullet-proof here because we lost the
waitForRunning() but in other hand, the tests were passing locally and the
start is called on another object now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Move from deprecated StrimziKafkaContainer to StrimziKafkaCluster [camel-quarkus]
apupier opened a new pull request, #8226: URL: https://github.com/apache/camel-quarkus/pull/8226 StrimziKafkaContainer has been removed in 0.114.0 which was already released in December 2025 even if not yet upgraded on Quarkus side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
