Re: [PR] fix(core): util class check hardening [camel]
squakez merged PR #20375: URL: https://github.com/apache/camel/pull/20375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(core): util class check hardening [camel]
squakez commented on code in PR #20375:
URL: https://github.com/apache/camel/pull/20375#discussion_r2618473867
##
core/camel-util/src/main/java/org/apache/camel/util/AnnotationHelper.java:
##
@@ -80,7 +80,7 @@ public static boolean hasAnnotation(
if (checkMetaAnnotations) {
for (Annotation a : elem.getAnnotations()) {
for (Annotation meta : a.annotationType().getAnnotations()) {
-if
(meta.annotationType().getName().equals(annotationType.getName())) {
+if (meta.annotationType() == annotationType) {
Review Comment:
Okey. This is quite an important consideration. I completely overlooked that
and did not consider the differences that an OSGI environment could involve.
I'll revert this change here and review the other recent changes to make sure
that it don't break the original design intents. That's exactly the reason why
I advocate for adding clarification comment notes in those parts of the code
that can be misinterpreted by any new maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(core): util class check hardening [camel]
davsclaus commented on code in PR #20375:
URL: https://github.com/apache/camel/pull/20375#discussion_r2613572567
##
core/camel-util/src/main/java/org/apache/camel/util/AnnotationHelper.java:
##
@@ -80,7 +80,7 @@ public static boolean hasAnnotation(
if (checkMetaAnnotations) {
for (Annotation a : elem.getAnnotations()) {
for (Annotation meta : a.annotationType().getAnnotations()) {
-if
(meta.annotationType().getName().equals(annotationType.getName())) {
+if (meta.annotationType() == annotationType) {
Review Comment:
just mind about classloading - could be something about that or just how the
original code was coded. As with osgi then it was more complex and classes from
different osgi bundles may not match like that - though really not sure just a
thought on top of my head today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(core): util class check hardening [camel]
github-actions[bot] commented on PR #20375: URL: https://github.com/apache/camel/pull/20375#issuecomment-3645549708 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] fix(core): util class check hardening [camel]
squakez opened a new pull request, #20375: URL: https://github.com/apache/camel/pull/20375 Additionally fixing a few compilation warnings in test. # Description # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
