Re: [I] [examples] Unify command for native build [camel-quarkus]
jamesnetherton closed issue #8064: [examples] Unify command for native build URL: https://github.com/apache/camel-quarkus/issues/8064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [examples] Unify command for native build [camel-quarkus]
gansheer commented on issue #8064: URL: https://github.com/apache/camel-quarkus/issues/8064#issuecomment-3771725082 Thanks for the analysis and I agree with applying quarkus suggestions on our usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [examples] Unify command for native build [camel-quarkus]
JiriOndrusek commented on issue #8064: URL: https://github.com/apache/camel-quarkus/issues/8064#issuecomment-3768459276 I checked the differences between `-pnative` and `-dnative`. * **-Dnative** is the correct Quarkus way of requesting native build. It seems to be a shortcut for `-Dquarkus.package.type=native`. Parameter triggers the native build. * **-Pnative** is CQ's (maven) profile for triggering the native build. Having profile and using `-Pnative` allows us for example to disable native build by removing the profile. I found a statement in one of the top [Quarkus guides](https://quarkus.io/guides/building-native-image) (about native build): ``` We use a profile because, you will see very soon, packaging the native executable takes a few minutes. You could just pass -Dquarkus.native.enabled=true as a property on the command line, however it is better to use a profile as this allows native image tests to also be run. ``` With the fact, that * we provide `native` profiles to all modules (including examples) * profile defines maven plugin for running integration tests * Quarkus suggests to use `-Pnative` in order to run native image tests correctly I'd say to keep using `-Pnative` as it is the correct way in our case. That brings us to: * as @gansheer noticed, that the empty generated Quarkus project suggest to use `-Dnative` and also contains `native profile`, this is actually correct. The `-Dnative` is used only for creation if the native executable build (without running tests). The `native` profile seems to be a template for the case you are adding integration tests running with native image. * the different places in the camel-quarkus-examples. All [occurrences](https://github.com/search?q=repo%3Aapache%2Fcamel-quarkus-examples%20-pnative&type=code) of `-Pnative` (except the CI -build.yaml), should be replaced by `-Dnative` -> because all the cases describes a way to creative native build (and we should be aligned with Quarkus on it) WDYT @aldettinger , @gansheer , @jamesnetherton -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [examples] Unify command for native build [camel-quarkus]
gansheer commented on issue #8064: URL: https://github.com/apache/camel-quarkus/issues/8064#issuecomment-3641286436 Small addition on the subject: when you create a new project using `io.quarkus:quarkus-maven-plugin:3.27.1:create` you end up with documentation (the README.md) using `-Dnative` and a pom file with the native profile. It's a little bit confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [examples] Unify command for native build [camel-quarkus]
aldettinger commented on issue #8064: URL: https://github.com/apache/camel-quarkus/issues/8064#issuecomment-3640925632 This commit mention this is what is recommended by quarkus: https://github.com/quarkusio/quarkus/commit/0b8a4f087979ca1e9cc3c4f951aaff300e87d51e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [examples] Unify command for native build [camel-quarkus]
aldettinger commented on issue #8064: URL: https://github.com/apache/camel-quarkus/issues/8064#issuecomment-3640902207 Whao, well done remembering that. It's been such a long time that the rationale behind this is totally forgotten :) The only tangible element would be that the [quarkus native doc](https://quarkus.io/guides/building-native-image) is using '-Dnative'. I would say it still applies. We can dig more with the quarkus team if more explanation are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [examples] Unify command for native build [camel-quarkus]
JiriOndrusek commented on issue #8064: URL: https://github.com/apache/camel-quarkus/issues/8064#issuecomment-3640751834 @aldettinger I see your comment https://github.com/apache/camel-quarkus-examples/pull/194#discussion_r1542708856, does this still apply? (do we prefer -Dnative over -Pnative)> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
