Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
jamesnetherton commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-354925 I'll close since #7969 is merged and will keep a watch on CI over the coming days to see if it occurs again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
jamesnetherton closed issue #7897: Flaky test GrpcTest.forwardOnError (on windows?) URL: https://github.com/apache/camel-quarkus/issues/7897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
llowinge commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3532702840 I hope this attempt to fix it https://github.com/apache/camel-quarkus/pull/7969 will resolve the flakiness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
jamesnetherton commented on issue #7897:
URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3480980023
Digging a bit more. We are perhaps not defining the `StreamObserver`
correctly in the test .
[JavaDoc](https://grpc.github.io/grpc-java/javadoc/io/grpc/stub/StreamObserver.html#onNext(V))
about `StreamObserver.onNext` states:
> If an exception is thrown by an implementation the caller is expected to
terminate the stream by calling onError(Throwable) with the caught exception
prior to propagating it.
So we should perhaps in `PongResponseStreamObserver.onNext` be doing:
```java
if (simulateError) {
onError(new IllegalStateException("Forced exception"));
// Maybe also throw & propagate the exception here
}
```
Otherwise it is not guaranteed that gRPC will call onError itself internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
jamesnetherton commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3480623133 The problem is being able to reliably reproduce and debug this. I tested in a memory and CPU constrained Windows VM and test passes reliably. It's notable looking at the CI logs that GitHub Windows runners just seem to be very slow. The gRPC test app takes 6 seconds to start, Vs 1 - 1.5 seconds on the VM I tested with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
llowinge commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3480133877 Thanks @apupier for spotting. Then i think it will probably need some further investigation why JDK25 + Windows is behaving like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
apupier commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3479739313 this test failed again on last weekly build https://github.com/apache/camel-quarkus/actions/runs/19006679327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
llowinge commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3479467517 Thank you @apupier . This is the relevant log: ``` 2025-10-24 14:27:58,462 INFO [org.apa.cam.qua.com.grp.it.GrpcTest] (main) Running test method: forwardOnError() 2025-10-24 14:27:58,463 INFO [org.apa.cam.qua.com.grp.it.GrpcTest] (main) forwardOnError: preparing observers 2025-10-24 14:27:58,463 INFO [org.apa.cam.qua.com.grp.it.GrpcTest] (main) forwardOnError: calling onNext(null) 2025-10-24 14:27:58,463 INFO [org.apa.cam.qua.com.grp.it.GrpcTest] (main) forwardOnError: waiting latch.await(5s) 2025-10-24 14:27:58,473 INFO [org.apa.cam.qua.com.grp.it.GrpcTest] (grpc-default-executor-0) PongResponseStreamObserver#onNext: Error: Exception in thread "grpc-default-executor-0" java.lang.IllegalStateException: Forced exception at org.apache.camel.quarkus.component.grpc.it.GrpcTest$PongResponseStreamObserver.onNext(GrpcTest.java:686) at org.apache.camel.quarkus.component.grpc.it.GrpcTest$PongResponseStreamObserver.onNext(GrpcTest.java:658) at io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onMessage(ClientCalls.java:568) at io.grpc.internal.DelayedClientCall$DelayedListener$2.run(DelayedClientCall.java:476) at io.grpc.internal.DelayedClientCall$DelayedListener.drainPendingCallbacks(DelayedClientCall.java:526) at io.grpc.internal.DelayedClientCall$1DrainListenerRunnable.runInContext(DelayedClientCall.java:315) at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614) at java.base/java.lang.Thread.run(Thread.java:1474) 2025-10-24 14:28:03,466 INFO [org.apa.cam.qua.com.grp.it.GrpcTest] (main) Finished test forwardOnError ``` Basically the method `onError` wasn't called in 5s timeout after the simulated exception was thrown in `onNext`. Which is weird, as it should be high enough number. I would for now leave it as it is and we will see if it happens in future. We could be just really unlucky with some atypical slowness of the CI machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
apupier commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3479388275 it failed on this build https://github.com/apache/camel-quarkus/actions/runs/18781672392/job/53591221814 so all logs that can be available would be somewhere in it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Flaky test GrpcTest.forwardOnError (on windows?) [camel-quarkus]
llowinge commented on issue #7897: URL: https://github.com/apache/camel-quarkus/issues/7897#issuecomment-3450691347 @apupier Do you have a full log ? It could be handy to figure out what happened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
