Re: [I] Remove cassandra-quarkus cq-maven-plugin BOM configuration for lz4-java [camel-quarkus]
jamesnetherton closed issue #8188: Remove cassandra-quarkus cq-maven-plugin BOM configuration for lz4-java URL: https://github.com/apache/camel-quarkus/issues/8188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Remove cassandra-quarkus cq-maven-plugin BOM configuration for lz4-java [camel-quarkus]
ppalaga commented on issue #8188: URL: https://github.com/apache/camel-quarkus/issues/8188#issuecomment-3822195112 > I do not see any ignoredOverlap configuration for at.yawk.lz4:lz4-java anymore. Yeah, that's right, as @jamesnetherton has removed it in between, because it was not needed to workaround the overlap issue. It was enough to add `at.yawk.lz4:lz4-java:*:*:*:*` to wokaround it. So `at.yawk.lz4:lz4-java:*:*:*:*` should be removed now that we are on a Quarkus version managing `at.yawk.lz4:lz4-java`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Remove cassandra-quarkus cq-maven-plugin BOM configuration for lz4-java [camel-quarkus]
dheeraj12347 commented on issue #8188: URL: https://github.com/apache/camel-quarkus/issues/8188#issuecomment-3821922699 I checked the current main branch. I can see at.yawk.lz4:lz4-java is excluded in the cq-maven-plugin configuration via resolutionExclude, with a TODO pointing to this issue. I do not see any ignoredOverlap configuration for at.yawk.lz4:lz4-java anymore. From my reading of the discussion, it looks like the ignoredOverlap part has already been removed. Is there any further change expected on the CQ side for this issue (for example, when upstream Cassandra / Quarkus are aligned), or can this be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Remove cassandra-quarkus cq-maven-plugin BOM configuration for lz4-java [camel-quarkus]
dheeraj12347 commented on issue #8188: URL: https://github.com/apache/camel-quarkus/issues/8188#issuecomment-3821870490 I’d like to work on this. I’ll remove the unnecessary ignoredOverlap configuration for at.yawk.lz4:lz4-java and verify the BOM build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Remove cassandra-quarkus cq-maven-plugin BOM configuration for lz4-java [camel-quarkus]
ppalaga commented on issue #8188: URL: https://github.com/apache/camel-quarkus/issues/8188#issuecomment-3789289588 > @ppalaga not sure if the build failure should be considered a bug in the `cq-maven-plugin` `bom-overlaps` feature? > > ``` > [ERROR] The following artifacts are managed in both org.apache.camel.quarkus:camel-quarkus-bom:3.31.0-SNAPSHOT and org.apache.camel.quarkus:camel-quarkus-bom:3.31.0-SNAPSHOT: > [ERROR] - at.yawk.lz4:lz4-java 1.10.1 ✅ 1.10.1 > [ERROR] > [ERROR] You may want to either remove the listed artifacts from org.apache.camel.quarkus:camel-quarkus-bom:3.31.0-SNAPSHOT or add them to > ``` > > `at.yawk.lz4:lz4-java` is not defined directly in `camel-quarkus-bom`. It is now being pulled in via `quarkus-cassandra-bom`: > > https://github.com/datastax/cassandra-quarkus/blob/736a91524ce86496bf73992a3b21382fe59bb85f/bom/pom.xml#L63-L68 I would say `bom-overlaps` did the right thing not allowing `at.yawk.lz4:lz4-java` to end up in our flattened BOM. > For now, I can fix these issues in CQ. I can see you did two things to workaround the problem on our side: 1. `at.yawk.lz4:lz4-java:*:*:*:*` and 2. `at.yawk.lz4:lz4-java` Ideally we need `cassandra-quarkus` to upgrade to Quarkus 3.31 and remove `lz4-java` from `cassandra-quarkus-bom`. I had a quick attempt at doing this and it did not seem trivial at first glance. Out of those, only the first one really does what we want: not to take over the `at.yawk.lz4:lz4-java` entry from Cassandra BOM to our flattened and minimized BOM. `at.yawk.lz4:lz4-java` can be removed. > Ideally we need `cassandra-quarkus` to upgrade to Quarkus 3.31 and remove `lz4-java` from `cassandra-quarkus-bom`. I had a quick attempt at doing this and it did not seem trivial at first glance. Yeah, fixing it in `cassandra-quarkus-bom` would be ideal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
