Re: [PR] Allow Smooks execution context to be overridden via header [camel]
davsclaus commented on PR #16129: URL: https://github.com/apache/camel/pull/16129#issuecomment-2450382808 Yes that sounds better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow Smooks execution context to be overridden via header [camel]
cjmamo commented on PR #16129: URL: https://github.com/apache/camel/pull/16129#issuecomment-2449775734 I realised that reading from the header might not be such a good idea when having more than one Smooks endpoint on the same route since it can cause undefined behaviour. Does it make sense to open another PR so that the execution context is set explicitly from an endpoint param? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow Smooks execution context to be overridden via header [camel]
davsclaus commented on code in PR #16129:
URL: https://github.com/apache/camel/pull/16129#discussion_r1824030592
##
components/camel-smooks/src/main/java/org/apache/camel/component/smooks/SmooksConstants.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.smooks;
+
+import org.apache.camel.spi.Metadata;
+
+/**
+ * Smooks constants
+ */
+public final class SmooksConstants {
+
+@Metadata(label = "common (advanced)", description = "The Smooks execution
context.",
Review Comment:
label = "advanced"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow Smooks execution context to be overridden via header [camel]
davsclaus merged PR #16129: URL: https://github.com/apache/camel/pull/16129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow Smooks execution context to be overridden via header [camel]
davsclaus commented on PR #16129: URL: https://github.com/apache/camel/pull/16129#issuecomment-2449316560 Can you update this file dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SmooksEndpointBuilderFactory.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow Smooks execution context to be overridden via header [camel]
github-actions[bot] commented on PR #16129: URL: https://github.com/apache/camel/pull/16129#issuecomment-2449194766 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
