Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-04 Thread via GitHub


tadayosi merged PR #16422:
URL: https://github.com/apache/camel/pull/16422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-04 Thread via GitHub


tadayosi commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2519076614

   Rebased to 4.10.0-SNAPSHOT. I'll merge it once CI passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-04 Thread via GitHub


github-actions[bot] commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2519075942

   :robot: The Apache Camel test robot will run the tests for you :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-04 Thread via GitHub


tadayosi commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2519075583

   /component-test ai


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-03 Thread via GitHub


tadayosi commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513962162

   @gansheer To be accurate, the protobuf license is not APL-2.0 but BSD:
   https://github.com/protocolbuffers/protobuf/issues/6798
   and BSD is allowed to include in an Apache project:
   https://www.apache.org/legal/resolved.html#category-a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-03 Thread via GitHub


tadayosi commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513926598

   @gansheer Camel's build tool requires and automatically add the license 
header to every text file in the project. But the actual file `any.proto` and 
the other proto files are originally copied from the TensorFlow repository 
as-is, that's why it has double license headers. My understanding is however 
that APL-2.0 is so permissive that there's no problem with doing so and there 
should be no practical implications with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-03 Thread via GitHub


gansheer commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513900419

   @tadayosi @davsclaus  How does declaring Apache and Google license works in 
practice for the 
filescomponents/camel-ai/camel-tensorflow-serving/src/main/proto/google/protobuf/any.proto
 and 
components/camel-ai/camel-tensorflow-serving/src/main/proto/google/protobuf/wrappers.proto
 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-02 Thread via GitHub


tadayosi commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513662091

   OK, then I'll keep it until 4.10 development starts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-02 Thread via GitHub


davsclaus commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513660291

   No its too late for 4.9, so it will be in 4.10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-02 Thread via GitHub


github-actions[bot] commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513633842

   :robot: The Apache Camel test robot will run the tests for you :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-02 Thread via GitHub


tadayosi commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513633321

   /component-test ai


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-02 Thread via GitHub


tadayosi commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513633049

   @davsclaus @oscerd Is it still possible to make it in the 4.9.0 release?  
It'd be great if we can have it in the 4.9.0 train. Otherwise, I'm fine with 
holding it for 4.10.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] CAMEL-21019: Create a Camel TensorFlow Serving component [camel]

2024-12-02 Thread via GitHub


github-actions[bot] commented on PR #16422:
URL: https://github.com/apache/camel/pull/16422#issuecomment-2513628507

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions 
to run
   
   * You can use the command `/component-test (camel-)component-name1 
(camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and 
`test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache 
Camel committers](https://camel.apache.org/community/team/#committers) have 
access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before 
sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org