Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
oscerd merged PR #21066: URL: https://github.com/apache/camel/pull/21066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
github-actions[bot] commented on PR #21066: URL: https://github.com/apache/camel/pull/21066#issuecomment-3799824457 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
oscerd merged PR #21062: URL: https://github.com/apache/camel/pull/21062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
oscerd commented on PR #21062: URL: https://github.com/apache/camel/pull/21062#issuecomment-3799711072 I'm going to remove the uselsess options -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
davsclaus commented on PR #21062: URL: https://github.com/apache/camel/pull/21062#issuecomment-3799694429 yeah also the options for views / collection type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
oscerd commented on PR #21062: URL: https://github.com/apache/camel/pull/21062#issuecomment-3799654842 > We may consider removing some of the jackson options you can configure on the dataformat since its for generic java mapping but this has pre compiled pojos from a fixed schema. > > But its maybe easier to do in a PR later Yes, enable and disable feature options doesn't make sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
davsclaus commented on PR #21062: URL: https://github.com/apache/camel/pull/21062#issuecomment-3799624198 We may consider removing some of the jackson options you can configure on the dataformat since its for generic java mapping but this has pre compiled pojos from a fixed schema. But its maybe easier to do in a PR later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
oscerd commented on code in PR #21062:
URL: https://github.com/apache/camel/pull/21062#discussion_r272747
##
components/camel-ocsf/src/generated/java/org/apache/camel/dataformat/ocsf/model/Account.java:
##
@@ -0,0 +1,408 @@
+
+package org.apache.camel.dataformat.ocsf.model;
+
+import java.util.ArrayList;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import javax.annotation.processing.Generated;
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+
+
+/**
+ * Account
+ *
+ * The Account object.
+ *
+ */
+@JsonInclude(JsonInclude.Include.NON_NULL)
+@JsonPropertyOrder({
+"name",
+"type",
+"uid",
+"labels",
+"tags",
+"type_id"
+})
+@Generated("jsonschema2pojo")
Review Comment:
But if we think it's better I can place them there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
oscerd commented on code in PR #21062:
URL: https://github.com/apache/camel/pull/21062#discussion_r2727476222
##
components/camel-ocsf/src/generated/java/org/apache/camel/dataformat/ocsf/model/Account.java:
##
@@ -0,0 +1,408 @@
+
+package org.apache.camel.dataformat.ocsf.model;
+
+import java.util.ArrayList;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import javax.annotation.processing.Generated;
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+
+
+/**
+ * Account
+ *
+ * The Account object.
+ *
+ */
+@JsonInclude(JsonInclude.Include.NON_NULL)
+@JsonPropertyOrder({
+"name",
+"type",
+"uid",
+"labels",
+"tags",
+"type_id"
+})
+@Generated("jsonschema2pojo")
Review Comment:
The schema is almost fixed and unless you change the underlined schema
through the python script (usually with a new ocsf schema release) the classes
will be like that for the time being, so I didn't really see the advantage of
placing them in target at build time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
Croway commented on code in PR #21062:
URL: https://github.com/apache/camel/pull/21062#discussion_r2727457343
##
components/camel-ocsf/src/generated/java/org/apache/camel/dataformat/ocsf/model/Account.java:
##
@@ -0,0 +1,408 @@
+
+package org.apache.camel.dataformat.ocsf.model;
+
+import java.util.ArrayList;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import javax.annotation.processing.Generated;
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+
+
+/**
+ * Account
+ *
+ * The Account object.
+ *
+ */
+@JsonInclude(JsonInclude.Include.NON_NULL)
+@JsonPropertyOrder({
+"name",
+"type",
+"uid",
+"labels",
+"tags",
+"type_id"
+})
+@Generated("jsonschema2pojo")
Review Comment:
What about removing these classes from src/main, and generate them under the
target folder at build time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] CAMEL-22903 - Add OCSF (Open Cybersecurity Schema Framework) DataForm… [camel]
github-actions[bot] commented on PR #21062: URL: https://github.com/apache/camel/pull/21062#issuecomment-3798948856 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
