Re: [PR] CSB-5888: implemented cookie handler for Spring Boot HTTP platform [camel-spring-boot]
Croway merged PR #1343: URL: https://github.com/apache/camel-spring-boot/pull/1343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CSB-5888: implemented cookie handler for Spring Boot HTTP platform [camel-spring-boot]
LostArtist commented on code in PR #1343:
URL:
https://github.com/apache/camel-spring-boot/pull/1343#discussion_r1920338724
##
components-starter/camel-platform-http-starter/src/test/java/org/apache/camel/component/platform/http/springboot/SpringBootPlatformHttpCertificationTest.java:
##
@@ -64,7 +64,7 @@
@CamelSpringBootTest
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
classes = { CamelAutoConfiguration.class,
SpringBootPlatformHttpCertificationTest.class,
SpringBootPlatformHttpCertificationTest.TestConfiguration.class,
-PlatformHttpComponentAutoConfiguration.class,
SpringBootPlatformHttpAutoConfiguration.class, })
+PlatformHttpComponentAutoConfiguration.class,
SpringBootPlatformHttpAutoConfiguration.class})
public class SpringBootPlatformHttpCertificationTest extends PlatformHttpBase {
Review Comment:
I replaced some tests in `SpringBootPlatformHttpCookiesTest` to fit the
methods from `CookieHandler` and left ones that were defined already (they
works just fine, however they're less flexible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] CSB-5888: implemented cookie handler for Spring Boot HTTP platform [camel-spring-boot]
Croway commented on code in PR #1343:
URL:
https://github.com/apache/camel-spring-boot/pull/1343#discussion_r1916980898
##
components-starter/camel-platform-http-starter/src/test/java/org/apache/camel/component/platform/http/springboot/SpringBootPlatformHttpCertificationTest.java:
##
@@ -64,7 +64,7 @@
@CamelSpringBootTest
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
classes = { CamelAutoConfiguration.class,
SpringBootPlatformHttpCertificationTest.class,
SpringBootPlatformHttpCertificationTest.TestConfiguration.class,
-PlatformHttpComponentAutoConfiguration.class,
SpringBootPlatformHttpAutoConfiguration.class, })
+PlatformHttpComponentAutoConfiguration.class,
SpringBootPlatformHttpAutoConfiguration.class})
public class SpringBootPlatformHttpCertificationTest extends PlatformHttpBase {
Review Comment:
moreover, was `SpringBootPlatformHttpCookiesTest` successful without your
fixes? maybe that test class need to be refactored? wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] CSB-5888: implemented cookie handler for Spring Boot HTTP platform [camel-spring-boot]
Croway commented on code in PR #1343:
URL:
https://github.com/apache/camel-spring-boot/pull/1343#discussion_r1916979385
##
components-starter/camel-platform-http-starter/src/test/java/org/apache/camel/component/platform/http/springboot/SpringBootPlatformHttpCertificationTest.java:
##
@@ -64,7 +64,7 @@
@CamelSpringBootTest
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
classes = { CamelAutoConfiguration.class,
SpringBootPlatformHttpCertificationTest.class,
SpringBootPlatformHttpCertificationTest.TestConfiguration.class,
-PlatformHttpComponentAutoConfiguration.class,
SpringBootPlatformHttpAutoConfiguration.class, })
+PlatformHttpComponentAutoConfiguration.class,
SpringBootPlatformHttpAutoConfiguration.class})
public class SpringBootPlatformHttpCertificationTest extends PlatformHttpBase {
Review Comment:
Could you add tests for removeCookie and addCookieValue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
