Re: [PR] Improve mdc.adoc [camel]
davsclaus merged PR #23124: URL: https://github.com/apache/camel/pull/23124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve mdc.adoc [camel]
abedurftig commented on PR #23124: URL: https://github.com/apache/camel/pull/23124#issuecomment-4424775485 Alright. There were some changes on main on the exact lines of code, so I rebased and cleaned up. So, the changes are really only the property names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve mdc.adoc [camel]
davsclaus commented on PR #23124: URL: https://github.com/apache/camel/pull/23124#issuecomment-4423299733 > Thanks for your feedback. I was not able to get it working right away. The fact that there might be a starter occurred too late, that's why I updated the docs. But if this is a convention, then maybe redundant. > > Are these conventions documented somewhere? in the camel spring boot docs https://camel.apache.org/camel-spring-boot/4.18.x/index.html > > Should I revert everything but the property names? yes thanks as suggested by @squakez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve mdc.adoc [camel]
github-actions[bot] commented on PR #23124: URL: https://github.com/apache/camel/pull/23124#issuecomment-4422502115 :test_tube: **CI tested the following changed modules:** - `components/camel-mdc` All tested modules (8 modules) - Camel :: JBang :: MCP - Camel :: JBang :: Plugin :: Route Parser - Camel :: JBang :: Plugin :: TUI - Camel :: JBang :: Plugin :: Validate - Camel :: Launcher :: Container - Camel :: MDC - Camel :: YAML DSL :: Validator - Camel :: YAML DSL :: Validator Maven Plugin --- :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25672795063) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve mdc.adoc [camel]
github-actions[bot] commented on PR #23124: URL: https://github.com/apache/camel/pull/23124#issuecomment-4422303113 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI. * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve mdc.adoc [camel]
abedurftig commented on PR #23124: URL: https://github.com/apache/camel/pull/23124#issuecomment-4422161720 Thanks for your feedback. I was not able to get it working right away. The fact that there might be a starter occurred too late, that's why I updated the docs. But if this is a convention, then maybe redundant. Are these conventions documented somewhere? Should I revert everything but the property names? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve mdc.adoc [camel]
davsclaus commented on PR #23124: URL: https://github.com/apache/camel/pull/23124#issuecomment-442990 For Spring Boot you should always use the -starter - that is for all of the camel components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
