Re: [PR] camel-langchain4j-agent: Lookup the agentId in the registry [camel]
Croway merged PR #20362: URL: https://github.com/apache/camel/pull/20362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] camel-langchain4j-agent: Lookup the agentId in the registry [camel]
Croway commented on PR #20362: URL: https://github.com/apache/camel/pull/20362#issuecomment-3643098444 @davsclaus I'll use the doInit for the initialization (though, the factory need the exchange therefore I'll leave it in the process). Regarding the autowiring, the `endpoint.getCamelContext().getRegistry().lookupByNameAndType(endpoint.getAgentId(), Agent.class)` is just a fallback strategy, the actual `agent` parameter is already autowired and work as expected. I've added it in case of multiple agents configured, this way, if you are lazy enough like me, it will be enough `langchain4j-agent:ollama` and `langchain4j-agent:openai` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] camel-langchain4j-agent: Lookup the agentId in the registry [camel]
davsclaus commented on PR #20362: URL: https://github.com/apache/camel/pull/20362#issuecomment-3642949054 yeah lookup in doInit and also consider making it autowired so it can happen automatic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] camel-langchain4j-agent: Lookup the agentId in the registry [camel]
github-actions[bot] commented on PR #20362: URL: https://github.com/apache/camel/pull/20362#issuecomment-3642859178 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
