Re: [PR] chore(core): support class check hardening [camel]
squakez merged PR #20374: URL: https://github.com/apache/camel/pull/20374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(core): support class check hardening [camel]
squakez commented on code in PR #20374:
URL: https://github.com/apache/camel/pull/20374#discussion_r2613597477
##
core/camel-support/src/main/java/org/apache/camel/support/MessageHelper.java:
##
@@ -365,7 +365,8 @@ public static String extractValueForLogging(
return "[Body is instance of java.io.Reader]";
} else if (obj instanceof Writer) {
return "[Body is instance of java.io.Writer]";
-} else if
(obj.getClass().getName().equals("javax.xml.transform.stax.StAXSource")) {
+// NOTE: the class is not available at compilation time
+} else if
(obj.getClass().getName().equals("jakarta.xml.transform.stax.StAXSource")) { //
NOSONAR
Review Comment:
Reverted, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] chore(core): support class check hardening [camel]
davsclaus commented on code in PR #20374:
URL: https://github.com/apache/camel/pull/20374#discussion_r2613560666
##
core/camel-support/src/main/java/org/apache/camel/support/MessageHelper.java:
##
@@ -365,7 +365,8 @@ public static String extractValueForLogging(
return "[Body is instance of java.io.Reader]";
} else if (obj instanceof Writer) {
return "[Body is instance of java.io.Writer]";
-} else if
(obj.getClass().getName().equals("javax.xml.transform.stax.StAXSource")) {
+// NOTE: the class is not available at compilation time
+} else if
(obj.getClass().getName().equals("jakarta.xml.transform.stax.StAXSource")) { //
NOSONAR
Review Comment:
This javax class is still inside the JDKs itself - such as inside my azul
java 21
There are no jakarta api jar with this class
https://search.maven.org/search?q=fc:jakarta.xml.transform.stax.StAXSource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] chore(core): support class check hardening [camel]
squakez commented on code in PR #20374:
URL: https://github.com/apache/camel/pull/20374#discussion_r2613378757
##
core/camel-support/src/main/java/org/apache/camel/support/MessageHelper.java:
##
@@ -365,7 +365,8 @@ public static String extractValueForLogging(
return "[Body is instance of java.io.Reader]";
} else if (obj instanceof Writer) {
return "[Body is instance of java.io.Writer]";
-} else if
(obj.getClass().getName().equals("javax.xml.transform.stax.StAXSource")) {
+// NOTE: the class is not available at compilation time
+} else if
(obj.getClass().getName().equals("jakarta.xml.transform.stax.StAXSource")) { //
NOSONAR
Review Comment:
@oscerd @davsclaus Is it correct to change to jakarta instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] chore(core): support class check hardening [camel]
github-actions[bot] commented on PR #20374: URL: https://github.com/apache/camel/pull/20374#issuecomment-3645476304 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
