Re: [PR] chore(trait): deprecate telemetry trait in favour of properties configuration [camel-k]
squakez merged PR #6407: URL: https://github.com/apache/camel-k/pull/6407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(trait): deprecate telemetry trait in favour of properties configuration [camel-k]
pkalsi97 commented on PR #6407: URL: https://github.com/apache/camel-k/pull/6407#issuecomment-3649236871 @squakez I have added it now. Please run the CI again. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(trait): deprecate telemetry trait in favour of properties configuration [camel-k]
github-actions[bot] commented on PR #6407: URL: https://github.com/apache/camel-k/pull/6407#issuecomment-3649228438 :warning: Unit test coverage report - coverage decreased from 51.6% to 51.5% (**-0.1%**) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(trait): deprecate telemetry trait in favour of properties configuration [camel-k]
squakez commented on PR #6407: URL: https://github.com/apache/camel-k/pull/6407#issuecomment-3649222997 > @squakez I've added a follow-up commit to update the e2e telemetry tests. > > I am not sure about it. can you review it and guide me ? `--dependency camel:opentelemetry` is needed since the trait was adding this via the capability. Should the migration docs mention this? or I am not thinking it correctly? Yes. From now on the user has to include the dependency. You can add a note to the migration docs, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(trait): deprecate telemetry trait in favour of properties configuration [camel-k]
pkalsi97 commented on PR #6407: URL: https://github.com/apache/camel-k/pull/6407#issuecomment-3647370737 @squakez I've added a follow-up commit to update the e2e telemetry tests. I am not sure about it. can you review it and guide me ? `--dependency camel:opentelemetry` is needed since the trait was adding this via the capability. Should the migration docs mention this? or I am not thinking it correctly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] chore(trait): deprecate telemetry trait in favour of properties configuration [camel-k]
pkalsi97 commented on PR #6407: URL: https://github.com/apache/camel-k/pull/6407#issuecomment-3646708594 @squakez I can work on this here itself, I'll update the test to use the new properties in some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
