Re: [PR] feat(ctrl): dry build - support Pipe BuildComplete phase and deploy/undeploy CLI [camel-k]
squakez merged PR #6408: URL: https://github.com/apache/camel-k/pull/6408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(ctrl): dry build - support Pipe BuildComplete phase and deploy/undeploy CLI [camel-k]
pkalsi97 commented on code in PR #6408:
URL: https://github.com/apache/camel-k/pull/6408#discussion_r2616893813
##
pkg/cmd/deploy.go:
##
@@ -32,9 +32,8 @@ func newCmdDeploy(rootCmdOptions *RootCmdOptions)
(*cobra.Command, *deployCmdOpt
RootCmdOptions: rootCmdOptions,
}
cmd := cobra.Command{
- Use: "deploy my-it",
- Short: "Deploy an Integration",
- Long:"Deploy an Integration that was previously built",
+ Use: "deploy ",
+ Short: "Deploy an Integration or Pipe that was previously
built with --dont-run-after-build flag",
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ctrl): dry build - support Pipe BuildComplete phase and deploy/undeploy CLI [camel-k]
squakez commented on code in PR #6408:
URL: https://github.com/apache/camel-k/pull/6408#discussion_r2616889596
##
pkg/cmd/deploy.go:
##
@@ -32,9 +32,8 @@ func newCmdDeploy(rootCmdOptions *RootCmdOptions)
(*cobra.Command, *deployCmdOpt
RootCmdOptions: rootCmdOptions,
}
cmd := cobra.Command{
- Use: "deploy my-it",
- Short: "Deploy an Integration",
- Long:"Deploy an Integration that was previously built",
+ Use: "deploy ",
+ Short: "Deploy an Integration or Pipe that was previously
built with --dont-run-after-build flag",
Review Comment:
don't mention the flag. We may have executed this with some other tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(ctrl): dry build - support Pipe BuildComplete phase and deploy/undeploy CLI [camel-k]
pkalsi97 commented on PR #6408: URL: https://github.com/apache/camel-k/pull/6408#issuecomment-3650643188 @squakez Thanks for the input. can we run the ci again? I'll refer to the PR mentioned above and investigate further to figure out why exactly these test are failing. If I am able to find a bug I'll raise the issue and PR fix. Alternatively we can directly create an issue stating that these e2e test are being skipped and we need to investigate further why they are failing and how they can be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
