Re: [PR] fix(ci): enable whitespace linter and fix violations [camel-k]
squakez merged PR #6367: URL: https://github.com/apache/camel-k/pull/6367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(ci): enable whitespace linter and fix violations [camel-k]
squakez commented on PR #6367: URL: https://github.com/apache/camel-k/pull/6367#issuecomment-3536184576 @pkalsi97 I have no preferences. It's more about how you prefer to do the development. What I think it matters is to use a single PR per each different linter when the changes required in the codebase are large and require some discussion. Otherwise, if it does not require large codebase changes, then, you can join more lint in each PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(ci): enable whitespace linter and fix violations [camel-k]
pkalsi97 commented on PR #6367: URL: https://github.com/apache/camel-k/pull/6367#issuecomment-3536180223 @squakez I am more than willing on to work on lint enforcement and fixing violations, but I need some input from you : Should each rule enablement and its fixes be submitted as an isolated PR? Or is it acceptable to group multiple rules and fixes into a single PR when the changes are related? ``` disable: - cyclop - depguard - err113 - exhaustive - exhaustruct - funcorder - funlen - gochecknoglobals - gochecknoinits - gocognit - gocyclo - godox - ireturn - lll - nilnil - nlreturn - paralleltest - perfsprint - revive - tagalign - tagliatelle - testpackage - varnamelen - whitespace - wrapcheck - wsl - wsl_v5 ``` Can you list down the ones you think should not be in disable, I'll work on those only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
