Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-10 Thread via GitHub


mcarlett commented on code in PR #17680:
URL: https://github.com/apache/camel/pull/17680#discussion_r2031124951


##
core/camel-core/src/test/java/org/apache/camel/impl/health/ContextHealthCheckTest.java:
##
@@ -0,0 +1,50 @@
+package org.apache.camel.impl.health;

Review Comment:
   thanks @oscerd for the fix 
https://github.com/apache/camel/commit/5cbceb51886ba8afdc0fa70e2763ae01b4e1c1d6



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-07 Thread via GitHub


Croway merged PR #17682:
URL: https://github.com/apache/camel/pull/17682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-07 Thread via GitHub


github-actions[bot] commented on PR #17682:
URL: https://github.com/apache/camel/pull/17682#issuecomment-2783188069

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions 
to run
   
   * You can use the command `/component-test (camel-)component-name1 
(camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and 
`test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache 
Camel committers](https://camel.apache.org/community/team/#committers) have 
access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before 
sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-07 Thread via GitHub


oscerd commented on code in PR #17680:
URL: https://github.com/apache/camel/pull/17680#discussion_r2031104864


##
core/camel-core/src/test/java/org/apache/camel/impl/health/ContextHealthCheckTest.java:
##
@@ -0,0 +1,50 @@
+package org.apache.camel.impl.health;

Review Comment:
   I'm regenerating and fixing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-07 Thread via GitHub


mcarlett commented on code in PR #17680:
URL: https://github.com/apache/camel/pull/17680#discussion_r2031107929


##
core/camel-core/src/test/java/org/apache/camel/impl/health/ContextHealthCheckTest.java:
##
@@ -0,0 +1,50 @@
+package org.apache.camel.impl.health;

Review Comment:
   sorry about that, I was fixing it after I pushed, but I was not on time 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-07 Thread via GitHub


davsclaus commented on code in PR #17680:
URL: https://github.com/apache/camel/pull/17680#discussion_r2031103161


##
core/camel-core/src/test/java/org/apache/camel/impl/health/ContextHealthCheckTest.java:
##
@@ -0,0 +1,50 @@
+package org.apache.camel.impl.health;

Review Comment:
   ASF license header is missing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-07 Thread via GitHub


oscerd merged PR #17680:
URL: https://github.com/apache/camel/pull/17680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] health-check: Fixes Camel context health check [camel]

2025-04-07 Thread via GitHub


github-actions[bot] commented on PR #17680:
URL: https://github.com/apache/camel/pull/17680#issuecomment-2782990990

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions 
to run
   
   * You can use the command `/component-test (camel-)component-name1 
(camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and 
`test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache 
Camel committers](https://camel.apache.org/community/team/#committers) have 
access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before 
sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org