Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]

2025-09-03 Thread via GitHub 


nvazquez commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249852930

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]

2025-09-03 Thread via GitHub 


blueorangutan commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249854922

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]

2025-09-03 Thread via GitHub 


Pearl1594 commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2319356718


##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -2903,6 +2904,31 @@ private boolean isGuestAarch64() {
 return AARCH64.equals(guestCpuArch);
 }
 
+private boolean isQemuVersionConflictingSMBiosForWindowsGuestVMs() {
+if (!isUbuntuOrDebianHost()) {
+return false;
+}
+return getHypervisorQemuVersion() > 
HYPERVISOR_QEMU_VERSION_PC_MACHINE_TYPE_FIX;
+}
+
+/**
+ * Observed the QEMU version included on Ubuntu 24 conflicts retrieval of 
UUID for Windows VMs
+ * References:
+ * - https://gitlab.com/libvirt/libvirt/-/issues/807";>Reported 
issue with CloudStack created Windows VMs on Ubuntu 24
+ * - https://gitlab.com/qemu-project/qemu/-/issues/2008";>Reported 
Issue on QEMU
+ * Workaround: Set an older OS type machine on the XML domain: 
'pc-i440fx-8.0'
+ */
+private void setGuestMachineType(GuestDef guest) {
+if (isGuestAarch64()) {
+guest.setMachineType(VIRT);
+} else if (isQemuVersionConflictingSMBiosForWindowsGuestVMs()) {
+// Please check the method javadoc
+guest.setMachineType("pc-i440fx-8.0");

Review Comment:
   I wonder if getting this as vm detail would be better? as opposed to 
hard-coding this to a specific machine type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]

2025-09-03 Thread via GitHub 


Pearl1594 commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2319353711


##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -2903,6 +2904,31 @@ private boolean isGuestAarch64() {
 return AARCH64.equals(guestCpuArch);
 }
 
+private boolean isQemuVersionConflictingSMBiosForWindowsGuestVMs() {
+if (!isUbuntuOrDebianHost()) {

Review Comment:
   we don't know if this issue is restricted to only ubuntu/debian - el10 "may" 
also face this issue..
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]

2025-09-03 Thread via GitHub 


codecov[bot] commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249735562

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11569?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 4.00%. Comparing base 
([`db5b6a5`](https://app.codecov.io/gh/apache/cloudstack/commit/db5b6a54a1e52ac1716e87c9f0fa0ae46310ba3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`cd9929f`](https://app.codecov.io/gh/apache/cloudstack/commit/cd9929f7c5a7ae058f22ed61df39b5430fe6844f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between 
BASE (db5b6a5) and HEAD (cd9929f). Click for more details.
   > 
   > HEAD has 1 upload less than BASE
   >
   >| Flag | BASE (db5b6a5) | HEAD (cd9929f) |
   >|--|--|--|
   >|unittests|1|0|
   >
   
   Additional details and impacted files
   
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   4.20   #11569   +/-   ##
   =
   - Coverage 16.17%4.00%   -12.17% 
   =
 Files  5656  402 -5254 
 Lines49801532635   -465380 
 Branches  60406 5798-54608 
   =
   - Hits  80538 1308-79230 
   + Misses   40851531177   -377338 
   + Partials   8962  150 -8812 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11569/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `4.00% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11569?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

[PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]

2025-09-03 Thread via GitHub 


nvazquez opened a new pull request, #11569:
URL: https://github.com/apache/cloudstack/pull/11569

   ### Description
   
   This PR fixes OS the machine type on newer QEMU versions (observed on Ubuntu 
24, please check the test matrix on: 
https://github.com/apache/cloudstack/issues/11512#issuecomment-3242172694)
   
   https://github.com/user-attachments/assets/3e57a186-7218-40d3-88c5-324e15d0b7fd";
 />
   
   Fixes: #11512 
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   Tested on Ubuntu 24 KVM host - deploying Windows VM and retrieving the UUID 
through the wmic command
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]