Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
DaanHoogland merged PR #12553: URL: https://github.com/apache/cloudstack/pull/12553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
blueorangutan commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822587302 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12553 (QA-JID-864) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
blueorangutan commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822513455 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
vishesh92 commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822508247 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
sureshanaparti commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822364215 Verified the filter issues - mainly in Hosts view (displaying Type= in fliter) and filter uuid displayed instead of name on scrolling the view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
blueorangutan commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822334396 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12553 (QA-JID-863) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
codecov[bot] commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822295084 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12553?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.16%. Comparing base ([`45d623e`](https://app.codecov.io/gh/apache/cloudstack/commit/45d623ec0d86ef040028b7cbc8339f7d0c7456f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c27ccb9`](https://app.codecov.io/gh/apache/cloudstack/commit/c27ccb94e1cc1e68da352b72a59aebceac851cde?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on 4.20. Additional details and impacted files ```diff @@Coverage Diff@@ ##4.20 #12553 +/- ## = - Coverage 4.16%4.16% -0.01% = Files403 403 Lines 3290532908 +3 Branches5881 5883 +2 = - Hits1371 1370 -1 - Misses 3136031362 +2 - Partials 174 176 +2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12553/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.16% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12553?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
blueorangutan commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822269445 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
vishesh92 commented on PR #12553: URL: https://github.com/apache/cloudstack/pull/12553#issuecomment-3822265809 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] UI: Prevent extra API calls in search filter on scrolling [cloudstack]
vishesh92 opened a new pull request, #12553:
URL: https://github.com/apache/cloudstack/pull/12553
### Description
This PR adds minor fixes on https://github.com/apache/cloudstack/pull/12552
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
