Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
weizhouapache commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2351929873
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -3292,6 +3292,9 @@ protected GuestDef createGuestFromSpec(VirtualMachineTO
vmTO, LibvirtVMDef vm, S
}
}
guest.setIothreads(customParams.containsKey(VmDetailConstants.IOTHREADS));
+if
(customParams.containsKey(VmDetailConstants.KVM_GUEST_OS_MACHINE_TYPE)) {
Review Comment:
can this be set by every user ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
harikrishna-patnala merged PR #11569: URL: https://github.com/apache/cloudstack/pull/11569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
harikrishna-patnala commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3273257782 > Would it make sense to have a documentation PR - adding a note on the limitation with retrieving UUID on a Windows VM, and how it can be mitigated using this @nvazquez. @nvazquez can you please raise the doc PR as suggested here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
blueorangutan commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250485684 @nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
nvazquez commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250481430 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
nvazquez commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253077166 Thanks @Pearl1594 I'll create a doc PR for that. @weizhouapache as discussed offline let's keep it targeted to main branch to avoid feature loss on upgrade to 4.21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
weizhouapache commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253681646 > @nvazquez is this worth raising the PR for 4.20 branch, could you check & change the base branch? @rohityadavcloud I have discussed with @nvazquez , our concern is, when users upgrade from 4.20.2 (assume this PR is included) to 4.21.0 (released already), the setting will be gone. my opinion is, unless very necessary, let's not introduce new api params, api responses, settings or db changes in minor versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
jmgsky commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253532555 This looks like it will fix my issue with booting a Juniper VSRX on cloudstack, but I think an option to set other parameters on the underlying qemu virtual machine would be more sustainable. Specifically, you can set `smbios-entry-point-type` on the machine (even newer i440fx-8.2 and beyond) and have it still use the older 32-bit smbios 2.x interface. [Here](https://github.com/qemu/qemu/blob/baa79455fa92984ff0f4b9ae94bed66823177a27/tests/functional/x86_64/test_acpi_bits.py#L321C1-L326C1) is the best example I can find of it's usage with qemu. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
nvazquez commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3254544676 @jmgsky thanks, the extraconfig will attempt to append the snippet as well on the XML domain, should have similar results than editing the XML directly. I couldn't find it mentioned on: https://libvirt.org/formatdomain.html, however checking the example you mentioned can you try the following? hvm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
jmgsky commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3254483058 @nvazquez - I'm actually not sure if that's right or not. I was trying to do it with `extraconfig` and qemu:args, but my VM wouldn't even start at that point. I switched to testing using `virsh edit` manually, and it doesn't like that xml snippet or `qemu:args`, so I'm honestly not even sure if there's a way to achieve that with libvirt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
nvazquez commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2322709861
##
api/src/main/java/com/cloud/vm/VmDetailConstants.java:
##
@@ -41,6 +41,7 @@ public interface VmDetailConstants {
String KVM_VNC_PORT = "kvm.vnc.port";
String KVM_VNC_ADDRESS = "kvm.vnc.address";
String KVM_VNC_PASSWORD = "kvm.vnc.password";
+String KVM_GUEST_OS_TYPE_MACHINE = "kvm.guest.os.type.machine";
Review Comment:
Thanks @weizhouapache, addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
nvazquez commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253929401 Hi @jmgsky thanks for your input. I think that can be addressed on a separate PR. I couldn't find references for this attribute on the libvirt documentation, but seems it should be wrapped as a feature on the XML domain. Can you please confirm if this snippet looks correct for a running domain? hvm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
weizhouapache commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2322105149
##
api/src/main/java/com/cloud/vm/VmDetailConstants.java:
##
@@ -41,6 +41,7 @@ public interface VmDetailConstants {
String KVM_VNC_PORT = "kvm.vnc.port";
String KVM_VNC_ADDRESS = "kvm.vnc.address";
String KVM_VNC_PASSWORD = "kvm.vnc.password";
+String KVM_GUEST_OS_TYPE_MACHINE = "kvm.guest.os.type.machine";
Review Comment:
```suggestion
String KVM_GUEST_OS_MACHINE_TYPE = "kvm.guest.os.machine.type";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
rohityadavcloud commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253164601 @nvazquez is this worth raising the PR for 4.20 branch, could you check & change the base branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
blueorangutan commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253259562 [SF] Trillian test result (tid-14206) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 55385 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11569-t14206-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
weizhouapache commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250656718 @nvazquez should the target branch be 4.20 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Pearl1594 commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250622357 Would it make sense to have a documentation PR - adding a note on the limitation with retrieving UUID on a Windows VM, and how it can be achieved using this @nvazquez. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
weizhouapache commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250490942 @nvazquez maybe machine.type, not type.machine Can it be set by regular user ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
blueorangutan commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250176955 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
blueorangutan commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250141871 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 14836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
blueorangutan commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249927196 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
nvazquez commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249925436 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
github-actions[bot] commented on PR #11569: URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249919810 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
