Re: [PR] [UI] Fix display of disk size and IOPS fields in the scale VM form [cloudstack]

2025-09-08 Thread via GitHub


weizhouapache commented on PR #11553:
URL: https://github.com/apache/cloudstack/pull/11553#issuecomment-3264950579

   Merging based on approvals and manual verification by @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [UI] Fix display of disk size and IOPS fields in the scale VM form [cloudstack]

2025-09-08 Thread via GitHub


weizhouapache merged PR #11553:
URL: https://github.com/apache/cloudstack/pull/11553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [UI] Fix display of disk size and IOPS fields in the scale VM form [cloudstack]

2025-09-03 Thread via GitHub


bernardodemarco commented on PR #11553:
URL: https://github.com/apache/cloudstack/pull/11553#issuecomment-3243287570

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [UI] Fix display of disk size and IOPS fields in the scale VM form [cloudstack]

2025-09-01 Thread via GitHub


blueorangutan commented on PR #11553:
URL: https://github.com/apache/cloudstack/pull/11553#issuecomment-3243302459

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11553 (QA-JID-735)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [UI] Fix display of disk size and IOPS fields in the scale VM form [cloudstack]

2025-09-01 Thread via GitHub


blueorangutan commented on PR #11553:
URL: https://github.com/apache/cloudstack/pull/11553#issuecomment-3243288192

   @bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [UI] Fix display of disk size and IOPS fields in the scale VM form [cloudstack]

2025-09-01 Thread via GitHub


codecov[bot] commented on PR #11553:
URL: https://github.com/apache/cloudstack/pull/11553#issuecomment-3243105322

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11553?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 4.28%. Comparing base 
([`d161dc7`](https://app.codecov.io/gh/apache/cloudstack/commit/d161dc76699535d460950ad16dcac1bd8abf7c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`5d871c1`](https://app.codecov.io/gh/apache/cloudstack/commit/5d871c10b8ac892bdf558c66f9ece5217e236029?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between 
BASE (d161dc7) and HEAD (5d871c1). Click for more details.
   > 
   > HEAD has 1 upload less than BASE
   >
   >| Flag | BASE (d161dc7) | HEAD (5d871c1) |
   >|--|--|--|
   >|unittests|1|0|
   >
   
   Additional details and impacted files
   
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   4.19   #11553   +/-   ##
   =
   - Coverage 15.18%4.28%   -10.90% 
   =
 Files  5415  372 -5043 
 Lines47607329745   -446328 
 Branches  58125 5229-52896 
   =
   - Hits  72279 1275-71004 
   + Misses   39570628324   -367382 
   + Partials   8088  146 -7942 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11553/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `4.28% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11553?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [UI] Fix display of disk size and IOPS fields in the scale VM form [cloudstack]

2025-09-01 Thread via GitHub


bernardodemarco commented on PR #11553:
URL: https://github.com/apache/cloudstack/pull/11553#issuecomment-3243096840

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]