Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
harikrishna-patnala merged PR #11230: URL: https://github.com/apache/cloudstack/pull/11230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
blueorangutan commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3117245279 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
blueorangutan commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3116840478 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
DaanHoogland commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3116838875 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
blueorangutan commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3112859068 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
DaanHoogland commented on code in PR #11230:
URL: https://github.com/apache/cloudstack/pull/11230#discussion_r2227807637
##
plugins/network-elements/internal-loadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java:
##
@@ -24,13 +27,16 @@
import javax.inject.Inject;
+import com.cloud.event.ActionEventUtils;
import org.apache.cloudstack.context.CallContext;
import org.apache.cloudstack.network.lb.InternalLoadBalancerVMService;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
-import org.mockito.Matchers;
+import org.mockito.ArgumentMatchers;
Review Comment:
```suggestion
```
##
plugins/network-elements/internal-loadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java:
##
@@ -105,7 +113,7 @@ public void setUp() {
Mockito.when(_accountMgr.getSystemUser()).thenReturn(new UserVO(1));
Mockito.when(_accountMgr.getSystemAccount()).thenReturn(new
AccountVO(2));
-
Mockito.when(_accountDao.findByIdIncludingRemoved(Matchers.anyLong())).thenReturn(new
AccountVO(2));
+
Mockito.when(_accountDao.findByIdIncludingRemoved(ArgumentMatchers.anyLong())).thenReturn(new
AccountVO(2));
Review Comment:
```suggestion
Mockito.when(_accountDao.findByIdIncludingRemoved(anyLong())).thenReturn(new
AccountVO(2));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
blueorangutan commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3112502457 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
harikrishna-patnala commented on code in PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#discussion_r2227789205 ## plugins/network-elements/internal-loadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java: ## @@ -24,13 +27,16 @@ import javax.inject.Inject; +import com.cloud.event.ActionEventUtils; import org.apache.cloudstack.context.CallContext; import org.apache.cloudstack.network.lb.InternalLoadBalancerVMService; import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; +import org.mockito.BDDMockito; import org.mockito.Matchers; Review Comment: Done @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
harikrishna-patnala commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3112499802 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
DaanHoogland commented on code in PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#discussion_r2223208030 ## plugins/network-elements/internal-loadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java: ## @@ -24,13 +27,16 @@ import javax.inject.Inject; +import com.cloud.event.ActionEventUtils; import org.apache.cloudstack.context.CallContext; import org.apache.cloudstack.network.lb.InternalLoadBalancerVMService; import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; +import org.mockito.BDDMockito; import org.mockito.Matchers; Review Comment: @harikrishna-patnala , does this make sense? it requires line 116 to have a simple adjustment as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
blueorangutan commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3101501542 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
blueorangutan commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3101308995 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
Copilot commented on code in PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#discussion_r2221391052 ## plugins/network-elements/internal-loadbalancer/src/test/java/org/apache/cloudstack/internallbvmmgr/InternalLBVMServiceTest.java: ## @@ -24,13 +27,16 @@ import javax.inject.Inject; +import com.cloud.event.ActionEventUtils; import org.apache.cloudstack.context.CallContext; import org.apache.cloudstack.network.lb.InternalLoadBalancerVMService; import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; +import org.mockito.BDDMockito; import org.mockito.Matchers; Review Comment: The import 'org.mockito.Matchers' is deprecated. Use 'org.mockito.ArgumentMatchers' instead, which is already imported. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
sureshanaparti commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3101301409 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
sureshanaparti commented on code in PR #11230:
URL: https://github.com/apache/cloudstack/pull/11230#discussion_r2221346638
##
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##
@@ -1472,6 +1475,8 @@ public boolean maintain(final long hostId) throws
AgentUnavailableException {
}
@Override
+@DB
+@ActionEvent(eventType = EventTypes.EVENT_MAINTENANCE_PREPARE,
eventDescription = "maintenance for host", async = true)
Review Comment:
```suggestion
@ActionEvent(eventType = EventTypes.EVENT_MAINTENANCE_PREPARE,
eventDescription = "prepare maintenance for host", async = true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
harikrishna-patnala closed pull request #11230: Added events for snapshots, vmsnapshots, internalLB operations URL: https://github.com/apache/cloudstack/pull/11230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Added events for snapshots, vmsnapshots, internalLB operations [cloudstack]
codecov[bot] commented on PR #11230: URL: https://github.com/apache/cloudstack/pull/11230#issuecomment-3082993598 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11230?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.28%. Comparing base [(`06c80cd`)](https://app.codecov.io/gh/apache/cloudstack/commit/06c80cdbe9149abdf86a20df27b620b379e5e1b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2b578ae`)](https://app.codecov.io/gh/apache/cloudstack/commit/2b578ae639b07173d7476f9627d27a7f4ca815b2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on 4.19. > :exclamation: There is a different number of reports uploaded between BASE (06c80cd) and HEAD (2b578ae). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (06c80cd) | HEAD (2b578ae) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #11230 +/- ## = - Coverage 15.18%4.28% -10.91% = Files 5415 372 -5043 Lines47588829746 -446142 Branches 58094 5230-52864 = - Hits 72256 1274-70982 + Misses 39554628327 -367219 + Partials 8086 145 -7941 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11230/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11230/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11230/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11230?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
