Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4043564322 [SF] Trillian test result (tid-15605) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 50269 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12419-t15605-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4038786859 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4038775085 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4038643824 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4038125100 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 17092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4037751209 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4037745605 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4037578054 [SF] Trillian test result (tid-15598) Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 61724 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12419-t15598-vmware-70u3.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_deploy_more_vms_than_limit_allows | `Error` | 125.32 | test_deploy_vms_in_parallel.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4037108036 [SF] Trillian test result (tid-15599) Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9 Total time taken: 56871 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12419-t15599-xcpng82.zip Smoke tests completed. 105 look OK, 36 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 300.42 | test_primary_storage.py test_01_primary_storage_iscsi | `Error` | 303.37 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.29 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.49 | test_primary_storage.py ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py test_09_project_suspend | `Error` | 1.10 | test_projects.py test_10_project_activation | `Error` | 1.09 | test_projects.py ContextSuite context=TestPurgeExpungedVms>:setup | `Error` | 0.00 | test_purge_expunged_vms.py test_another_user_can_allocate_ip_after_quarantined_has_ended_network | `Error` | 6.50 | test_quarantined_ips.py test_another_user_can_allocate_ip_after_quarantined_has_ended_vpc | `Error` | 0.36 | test_quarantined_ips.py test_only_owner_can_allocate_ip_in_quarantine_network | `Error` | 0.32 | test_quarantined_ips.py test_only_owner_can_allocate_ip_in_quarantine_vpc | `Error` | 0.36 | test_quarantined_ips.py test_deploy_vm_with_registered_userdata | `Error` | 7.25 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 7.60 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 7.67 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 7.51 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_params | `Error` | 7.23 | test_register_userdata.py test_link_and_unlink_userdata_to_template | `Error` | 7.47 | test_register_userdata.py test_user_userdata_crud | `Error` | 7.50 | test_register_userdata.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestVMSchedule>:setup | `Error` | 0.00 | test_vm_schedule.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestResourceNames>:setup | `Error` | 0.00 | test_resource_names.py ContextSuite context=TestRestoreVM>:setup | `Error` | 0.00 | test_restore_vm.py test_change_service_offering_for_vm_with_snapshots | `Error` | 1.37 | test_vm_snapshots.py ContextSuite context=TestVmSnapshot>:setup | `Error` | 14.34 | test_vm_snapshots.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.20 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.19 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.36 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_verify_ipv6_vpc | `Error` | 6.45 | test_vpc_ipv6.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.28 | test_service_offerings.py ContextSuite context=TestSetSourceNatIp>:setup | `Error` | 0.00 | test_set_sourcenat.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestVolumes>:setup | `Error` | 5.68 | test_volumes.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.04 | test
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4036760292 [SF] Trillian test result (tid-15596) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 51479 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12419-t15596-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_snapshot_to_volume | `Error` | 1.11 | test_snapshots.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4034358228 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [16.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4032132397 @DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4032120911 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4031983396 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4031411804 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4031406819 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-4025414029 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [16.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3895603214 @Pearl1594 , the snapshot error seems persistent. needs looking at. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3894026372 [SF] Trillian test result (tid-15443) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 53013 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12419-t15443-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_snapshot_to_volume | `Error` | 1.16 | test_snapshots.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3889404788 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3889392305 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3889390919 It seems the snapshot error is consistent, we need to revisit that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3888463313 [SF] Trillian test result (tid-15435) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 55853 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12419-t15435-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_arping_in_ssvm | `Failure` | 5.21 | test_diagnostics.py test_01_snapshot_to_volume | `Error` | 1.17 | test_snapshots.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3883720417 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3883716385 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3881002423 [SF] Trillian test result (tid-15425) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 51453 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12419-t15425-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_snapshot_to_volume | `Error` | 1.15 | test_snapshots.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3875744585 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3875742552 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3872760617 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3872524726 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [16.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-387454 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3872172057 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3872118904 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3855949989 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [16.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3855894805 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3855653808 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
Pearl1594 commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3855640787 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r276785
##
tools/marvin/setup.py:
##
@@ -27,7 +27,7 @@
raise RuntimeError("python setuptools is required to build Marvin")
-VERSION = "4.20.3.0-SNAPSHOT"
+VERSION = "4.20.3.0"
Review Comment:
```suggestion
VERSION = “4.20.3.0-SNAPSHOT"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2767644867
##
server/src/main/java/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesServiceImpl.java:
##
@@ -673,7 +673,7 @@ private boolean applyGlobalLoadBalancerRuleConfig(long
gslbRuleId, boolean revok
// set site as 'local' for the site in that zone
for (Pair innerLoopZoneId : gslbSiteIds) {
SiteLoadBalancerConfig siteLb =
zoneSiteLoadbalancerMap.get(innerLoopZoneId.first());
-siteLb.setLocal(zoneId.first() == innerLoopZoneId.first());
+
siteLb.setLocal(zoneId.first().equals(innerLoopZoneId.first()));
Review Comment:
```suggestion
siteLb.setLocal(Objects.equals(zoneId.first(),
innerLoopZoneId.first()));
```
would need an import as well probably
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on code in PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2767640281 ## tools/marvin/setup.py: ## Review Comment: this is probably accidental -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2767634731
##
api/src/main/java/org/apache/cloudstack/api/command/admin/backup/UpdateBackupOfferingCmd.java:
##
@@ -83,8 +83,8 @@ public Boolean getAllowUserDrivenBackups() {
public void execute() {
try {
if (StringUtils.isAllEmpty(getName(), getDescription()) &&
getAllowUserDrivenBackups() == null) {
-throw new InvalidParameterValueException(String.format("Can't
update Backup Offering [id: %s] because there are no parameters to be updated,
at least one of the " +
-"following should be informed: name, description or
allowUserDrivenBackups.", id));
+throw new InvalidParameterValueException(String.format("Can't
update Backup Offering [id: %s] because there are no parameters to be updated,"
+
+" at least one of the following should be informed:
name, description or allowUserDrivenBackups.", id));
Review Comment:
```suggestion
" at least one of the following should be passed:
name, description or allowUserDrivenBackups.", id));
```
??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3848541663 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [16.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3823286210 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [12.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3823014094 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [12.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3821770971 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [12.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3821280340 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [12.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
Pearl1594 commented on code in PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693955136 ## .github/linters/codespell.txt: ## @@ -188,6 +188,7 @@ environmnet equivalant erro erronous +errorprone Review Comment: codespell matches words case insensitively, so this shouldn't matter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
Pearl1594 commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693942572
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -5391,7 +5391,7 @@ public Vlan updateVlanAndPublicIpRange(final long id,
String startIp,
}
final Boolean isRangeForSystemVM = checkIfVlanRangeIsForSystemVM(id);
-if (forSystemVms != null && isRangeForSystemVM != forSystemVms) {
+if (forSystemVms != null && !isRangeForSystemVM.equals(forSystemVms)) {
Review Comment:
`checkIfVlanRangeIsForSystemVM` returns boolean so in all likelihood this
cant be null though assigned to a `Boolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
Pearl1594 commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693933946
##
plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBaseTest.java:
##
@@ -112,6 +113,7 @@ public void beforeTest() throws XenAPIException,
XmlRpcException {
}
+@Ignore
Review Comment:
this was never run in this test file, but called in other tests that have
the appropriate annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
DaanHoogland commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693622275
##
engine/schema/src/main/java/com/cloud/upgrade/dao/DatabaseAccessObject.java:
##
@@ -98,7 +98,7 @@ public boolean indexExists(Connection conn, String tableName,
String indexName)
return true;
}
} catch (SQLException e) {
-logger.debug(String.format("Index %s doesn't exist, ignoring
exception:", indexName, e.getMessage()));
+logger.debug(String.format("Index %s doesn't exist, ignoring
exception:", indexName), e.getMessage());
Review Comment:
```suggestion
logger.debug("Index {} doesn't exist, ignoring exception: {}",
indexName, e.getMessage());
```
##
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/XenServerGuru.java:
##
@@ -181,10 +181,9 @@ public Pair getCommandHostDelegation(long
hostId, Command cmd) {
logger.debug("We are returning the default host to execute
commands because the target hypervisor of the source data is not XenServer.");
return defaultHostToExecuteCommands;
}
-// only now can we decide, now we now we're only deciding for ourselves
if (cmd instanceof StorageSubSystemCommand) {
if (logger.isTraceEnabled()) {
-logger.trace(String.format("XenServer StrorageSubSystemCommand
re always executed in sequence (command of type %s to host %l).",
cmd.getClass(), hostId));
+logger.trace(String.format("XenServer StrorageSubSystemCommand
is always executed in sequence (command of type %s to host %s).",
cmd.getClass(), hostId));
}
Review Comment:
```suggestion
logger.trace("XenServer StrorageSubSystemCommand is always
executed in sequence (command of type {} to host {}).", cmd.getClass(), hostId);
```
##
api/src/main/java/org/apache/cloudstack/api/command/admin/backup/UpdateBackupOfferingCmd.java:
##
@@ -83,7 +83,7 @@ public Boolean getAllowUserDrivenBackups() {
public void execute() {
try {
if (StringUtils.isAllEmpty(getName(), getDescription()) &&
getAllowUserDrivenBackups() == null) {
-throw new InvalidParameterValueException(String.format("Can't
update Backup Offering [id: %s] because there are no parameters to be updated,
at least one of the",
+throw new InvalidParameterValueException(String.format("Can't
update Backup Offering [id: %s] because there are no parameters to be updated,
at least one of the " +
"following should be informed: name, description or
allowUserDrivenBackups.", id));
Review Comment:
```suggestion
throw new InvalidParameterValueException(String.format(
"Can't update Backup Offering [id: %s] because there are
no parameters to be updated,” +
" at least one of the following should be informed:
name, description or allowUserDrivenBackups.",
id));
```
(just readability??)
##
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentAttache.java:
##
@@ -497,6 +498,11 @@ public void process(final Answer[] answers) {
*/
protected abstract boolean isClosed();
+@Override
+public int hashCode() {
+return Objects.hash(_id, _uuid, _name);
Review Comment:
or add _uuid and _name comparison to `equals()`? actually only _uuid and
_name makes more sense.
##
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##
@@ -1730,7 +1730,7 @@ public void stop(final String vmUuid) throws
ResourceUnavailableException {
} catch (final OperationTimedoutException e) {
throw new AgentUnavailableException(String.format("Unable to stop
vm [%s] because the operation to stop timed out", vmUuid), e.getAgentId(), e);
} catch (final ConcurrentOperationException e) {
-throw new CloudRuntimeException(String.format("Unable to stop vm
because of a concurrent operation", vmUuid), e);
+throw new CloudRuntimeException(String.format("Unable to stop vm:
%s because of a concurrent operation", vmUuid), e);
Review Comment:
```suggestion
throw new CloudRuntimeException(String.format("Unable to stop vm
[%s] because of a concurrent operation", vmUuid), e);
```
##
plugins/hypervisors/vmware/src/test/java/com/cloud/hypervisor/vmware/VmwareDatacenterApiUnitTest.java:
##
@@ -240,12 +241,16 @@ public void tearDown() throws Exception {
}
//@Test(expected = InvalidParameterValueException.class)
+@Test
Review Comment:
true for the below as well. or-else we could either fix or clean up this
test file and keep only sensible tests.
##
server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java:
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
Copilot commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693121384
##
plugins/storage/volume/nexenta/src/main/java/org/apache/cloudstack/storage/datastore/util/NexentaStorAppliance.java:
##
@@ -242,7 +248,7 @@ boolean isLuExists(String luName) {
return response!= null && response.getResult() > 0;
}
-@SuppressWarnings("unused")
+@SuppressWarnings({"unused", "EqualsHashCode", "EqualsAndHashCode",
"java:S2160", "errorprone"})
Review Comment:
The suppression annotation includes multiple different annotation names for
the same issue. The list contains "EqualsHashCode", "EqualsAndHashCode",
"java:S2160", and "errorprone" which are redundant. Consider standardizing to
use only the ErrorProne annotation "EqualsHashCode" or the SonarQube annotation
"java:S2160".
##
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentAttache.java:
##
@@ -497,6 +498,11 @@ public void process(final Answer[] answers) {
*/
protected abstract boolean isClosed();
+@Override
+public int hashCode() {
+return Objects.hash(_id, _uuid, _name);
Review Comment:
The hashCode implementation uses _id, _uuid, and _name, but the equals
method in AgentAttache only uses _id for comparison. The hashCode
implementation should be consistent with equals and only use _id to maintain
the equals-hashCode contract.
```suggestion
return Objects.hash(_id);
```
##
.github/linters/codespell.txt:
##
@@ -188,6 +188,7 @@ environmnet
equivalant
erro
erronous
+errorprone
Review Comment:
The codespell exclusion entry "errorprone" should be capitalized as
"ErrorProne" to match the actual tool name, or removed entirely as it's a valid
technical term that doesn't need to be in the codespell ignore list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
vishesh92 commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693101425
##
server/src/main/java/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesServiceImpl.java:
##
@@ -673,7 +673,7 @@ private boolean applyGlobalLoadBalancerRuleConfig(long
gslbRuleId, boolean revok
// set site as 'local' for the site in that zone
for (Pair innerLoopZoneId : gslbSiteIds) {
SiteLoadBalancerConfig siteLb =
zoneSiteLoadbalancerMap.get(innerLoopZoneId.first());
-siteLb.setLocal(zoneId.first() == innerLoopZoneId.first());
+
siteLb.setLocal(zoneId.first().equals(innerLoopZoneId.first()));
Review Comment:
I just have one concern about changes like this is that this could cause NPE
if if `zoneId.first()` is `null` for whatever reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
vishesh92 commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693095804
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -5391,7 +5391,7 @@ public Vlan updateVlanAndPublicIpRange(final long id,
String startIp,
}
final Boolean isRangeForSystemVM = checkIfVlanRangeIsForSystemVM(id);
-if (forSystemVms != null && isRangeForSystemVM != forSystemVms) {
+if (forSystemVms != null && !isRangeForSystemVM.equals(forSystemVms)) {
Review Comment:
```suggestion
if (forSystemVms != null &&
!forSystemVms.equals(isRangeForSystemVM.)) {
```
to prevent NPE if `isRangeForSystemVM` is `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
vishesh92 commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693085889
##
plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBaseTest.java:
##
@@ -112,6 +113,7 @@ public void beforeTest() throws XenAPIException,
XmlRpcException {
}
+@Ignore
Review Comment:
Do we need `@Test` annotation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
vishesh92 commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693084189
##
plugins/hypervisors/vmware/src/test/java/com/cloud/hypervisor/vmware/VmwareDatacenterApiUnitTest.java:
##
@@ -240,12 +241,16 @@ public void tearDown() throws Exception {
}
//@Test(expected = InvalidParameterValueException.class)
+@Test
Review Comment:
```suggestion
@Test(expected = InvalidParameterValueException.class)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
sonarqubecloud[bot] commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3750881939 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) **Quality Gate failed** Failed conditions  [12.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=12419&metric=new_coverage&view=list) (required ≥ 40%) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=12419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix issues reported by Errorprone static analysis tool [cloudstack]
blueorangutan commented on PR #12419: URL: https://github.com/apache/cloudstack/pull/12419#issuecomment-3750862083 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
