Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
weizhouapache commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3285470912 Merging based on approvals and manual tests by @vladimirpetrov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
weizhouapache merged PR #11554: URL: https://github.com/apache/cloudstack/pull/11554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3283611886 [SF] Trillian test result (tid-14295) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 57125 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11554-t14295-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3280097077 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
sureshanaparti commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3280088152 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3269734949 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
sureshanaparti commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3269322719 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3269325006 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3269264564 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
sureshanaparti commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3269253404 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3249847324 [SF] Trillian Build Failed (tid-14203) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3244263272 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3247306088 [SF] Trillian test result (tid-14183) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 54999 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11554-t14183-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
weizhouapache commented on code in PR #11554:
URL: https://github.com/apache/cloudstack/pull/11554#discussion_r2315379771
##
server/src/main/java/com/cloud/server/StatsCollector.java:
##
@@ -1459,7 +1459,7 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
for (VmDiskStats vmDiskStat : vmDiskStats) {
VmDiskStatsEntry vmDiskStatEntry =
(VmDiskStatsEntry)vmDiskStat;
SearchCriteria sc_volume =
_volsDao.createSearchCriteria();
-sc_volume.addAnd("path",
SearchCriteria.Op.EQ, vmDiskStatEntry.getPath());
+sc_volume.addAnd("path",
SearchCriteria.Op.LIKE, vmDiskStatEntry.getPath() + "%");
Review Comment:
hope there is no regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3244412505 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
weizhouapache commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3244405755 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
codecov[bot] commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3243984001 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11554?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.63%. Comparing base ([`92e7593`](https://app.codecov.io/gh/apache/cloudstack/commit/92e75932967218240ceadd179996176fbca04694?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3b9a1b5`](https://app.codecov.io/gh/apache/cloudstack/commit/3b9a1b5febed9a8aebedc751ec913b0516e67e3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on 4.20. Additional details and impacted files ```diff @@Coverage Diff@@ ##4.20 #11554 +/- ## = - Coverage 4.00%3.63% -0.38% = Files402 441 +39 Lines 3262837019+4391 Branches5796 6785 +989 = + Hits1308 1345 +37 - Misses 3117035513+4343 - Partials 150 161 +11 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11554/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.63% <ø> (-0.38%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11554?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
blueorangutan commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3243969521 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] ScaleIO/PowerFlex smoke tests improvements, and some fixes [cloudstack]
sureshanaparti commented on PR #11554: URL: https://github.com/apache/cloudstack/pull/11554#issuecomment-3243964385 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
