Re: [PR] Update search filter size dynamically [cloudstack]
borisstoyanov merged PR #12552: URL: https://github.com/apache/cloudstack/pull/12552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update search filter size dynamically [cloudstack]
sureshanaparti commented on PR #12552: URL: https://github.com/apache/cloudstack/pull/12552#issuecomment-3822111783 LGTM. Verified the search filter view in qa/simulator env. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update search filter size dynamically [cloudstack]
blueorangutan commented on PR #12552: URL: https://github.com/apache/cloudstack/pull/12552#issuecomment-3822078661 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12552 (QA-JID-862) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update search filter size dynamically [cloudstack]
codecov[bot] commented on PR #12552: URL: https://github.com/apache/cloudstack/pull/12552#issuecomment-3822036700 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12552?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.16%. Comparing base ([`a6ccde4`](https://app.codecov.io/gh/apache/cloudstack/commit/a6ccde44c4bc3c2b4623aca6b55500a722144763?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bc9ba60`](https://app.codecov.io/gh/apache/cloudstack/commit/bc9ba600666479f663fd1bc034abdf9f0db2458d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (a6ccde4) and HEAD (bc9ba60). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (a6ccde4) | HEAD (bc9ba60) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #12552 +/- ## = - Coverage 16.26%4.16% -12.10% = Files 5660 403 -5257 Lines49990732905 -467002 Branches 60696 5881-54815 = - Hits 81316 1371-79945 + Misses 40952131360 -378161 + Partials 9070 174 -8896 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12552/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12552/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.16% <ø> (+0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12552/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12552?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update search filter size dynamically [cloudstack]
blueorangutan commented on PR #12552: URL: https://github.com/apache/cloudstack/pull/12552#issuecomment-3822031008 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update search filter size dynamically [cloudstack]
sureshanaparti commented on PR #12552: URL: https://github.com/apache/cloudstack/pull/12552#issuecomment-3822030042 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update search filter size dynamically [cloudstack]
Copilot commented on code in PR #12552:
URL: https://github.com/apache/cloudstack/pull/12552#discussion_r2744771450
##
ui/src/components/view/SearchFilter.vue:
##
@@ -175,6 +175,7 @@ export default {
immediate: true,
handler (newFilters) {
const clonedFilters = newFilters.map(filter => ({ ...filter }))
+this.searchFilters = clonedFilters.map(f => ({ ...f }))
Review Comment:
This assignment appears redundant as clonedFilters is already a cloned array
from line 177. The extra cloning via map(f => ({ ...f })) could be simplified
to just this.searchFilters = clonedFilters or this.searchFilters =
[...clonedFilters] if a new array reference is needed. This would improve code
clarity and reduce unnecessary object creation.
```suggestion
this.searchFilters = clonedFilters
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Update search filter size dynamically [cloudstack]
vishesh92 commented on PR #12552: URL: https://github.com/apache/cloudstack/pull/12552#issuecomment-3822016011 @blueoranugtan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
